[mypyc] Move setting of __cpyfunction__ outside of constructor#20630
Merged
p-sawicki merged 3 commits intopython:masterfrom Jan 22, 2026
Merged
[mypyc] Move setting of __cpyfunction__ outside of constructor#20630p-sawicki merged 3 commits intopython:masterfrom
p-sawicki merged 3 commits intopython:masterfrom
Conversation
JukkaL
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
__cpyfunction__attribute of callable class objects is initialized in the constructor, it might end up becomingNULLafter a freed instance is reused because the attribute gets cleared when deallocating the object and the constructor would only initialize it when creating a new instance.To fix this, move the initialization outside of the constructor and do it right after. This also makes it consistent with the
__mypyc_env__attribute.