Skip to content

[mypyc] ircheck: Check for incompatible signs in int ops #20685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 2 commits into from
Jan 29, 2026
+19 −0
Merged

[mypyc] ircheck: Check for incompatible signs in int ops #20685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d86bf8
[mypyc] ircheck: Check for incompatible signs in int ops
JukkaL Jan 29, 2026
b1b116b
Fix
JukkaL Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions mypyc/analysis/ircheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,10 @@ def expect_non_float(self, op: Op, v: Value) -> None:
if is_float_rprimitive(v.type):
self.fail(op, "Float not expected")

def expect_primitive_type(self, op: Op, v: Value) -> None:
if not isinstance(v.type, RPrimitive):
self.fail(op, f"RPrimitive expected, got {type(v.type).__name__}")

def visit_goto(self, op: Goto) -> None:
self.check_control_op_targets(op)

Expand Down Expand Up @@ -397,8 +401,23 @@ def visit_load_global(self, op: LoadGlobal) -> None:
pass

def visit_int_op(self, op: IntOp) -> None:
self.expect_primitive_type(op, op.lhs)
self.expect_primitive_type(op, op.rhs)
self.expect_non_float(op, op.lhs)
self.expect_non_float(op, op.rhs)
left = op.lhs.type
right = op.rhs.type
op_str = op.op_str[op.op]
if (
isinstance(left, RPrimitive)
and isinstance(right, RPrimitive)
and left.is_signed != right.is_signed
and (
op_str in ("+", "-", "*", "/", "%")
or (op_str not in ("<<", ">>") and left.size != right.size)
)
):
self.fail(op, f"Operand types have incompatible signs: {op.lhs.type}, {op.rhs.type}")

def visit_comparison_op(self, op: ComparisonOp) -> None:
self.check_compatibility(op, op.lhs.type, op.rhs.type)
Expand Down