Refactor State creation logic#20691
Merged
ilevkivskyi merged 1 commit intopython:masterfrom Jan 29, 2026
Merged
Conversation
hauntsaninja
approved these changes
Jan 29, 2026
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #933
This should be a pure refactoring unless i messed something up. This is needed to prepare to make
Stateserializeable, so that we can send graph over the network to build workers (which is required for parallel parsing). Also not having tons of custom logic in__init__()is a better style anyway.Note I make the new state factory a classmethod to minimize the diff. If there is a preference, I can make it a regular function.