Always disable sync in SQLite cache#21184
Merged
ilevkivskyi merged 1 commit intopython:masterfrom Apr 8, 2026
Merged
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Apr 8, 2026
JukkaL
reviewed
Apr 8, 2026
| # This is a bit unfortunate (as we may get corrupt cache after e.g. Ctrl + C), | ||
| # but without this flag, commits are *very* slow, especially when using HDDs, | ||
| # see https://www.sqlite.org/faq.html#q19 for details. | ||
| db.execute("PRAGMA synchronous=OFF") |
Collaborator
There was a problem hiding this comment.
I guess we could probably get away with having synchronous enabled on macOS, since they all have had SSDs for a long time now, but since we'll need this for parallel checking, it makes more sense to keep things consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21176
This seems to resolve all the HDD performance issues. Although this makes cache less durable, this is fine, as FS is not perfect in this sense either (and it doesn't really need to be that durable).