Skip to content

Commit 62515a3

Browse files
DEKHTIARJonathanmgornyAA-Turnerhugovkwillingc
authored
PEP 817: Wheel Variants: Beyond Platform Tags (#4740)
* PEP 817: Wheel Variants: Beyond Platform Tags * Code-Owners editing * Apply suggestions from code review Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> * Switch to plain quotation marks Signed-off-by: Michał Górny <mgorny@quansight.com> * Move "definitions" to "specification" section Signed-off-by: Michał Górny <mgorny@quansight.com> * Reflow the cupy package list Signed-off-by: Michał Górny <mgorny@quansight.com> * Update peps/pep-0817/appendix-variant-metadata-json-schema.rst Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> * [PEP Review] JSON Schema Indent switched to 2 * Replace the benchmark chart with SVG Signed-off-by: Michał Górny <mgorny@quansight.com> * Compact the SVG Signed-off-by: Michał Górny <mgorny@quansight.com> * Reflow text Reflow the text to restore correct text width after all the inline changes and applied suggestions. Signed-off-by: Michał Górny <mgorny@quansight.com> * Replace typographic apostrophes Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove double spaces introduced while reflowing Remove accidental double spaces that vim's `gq` introduced while I was reflowing the text. Thanks to @konstin for noticing. Signed-off-by: Michał Górny <mgorny@quansight.com> * Apply suggestions from code review Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> * Remove one more "induced" Signed-off-by: Michał Górny <mgorny@quansight.com> * Apply suggestions from code review Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Carol Willing <carolcode@willingconsulting.com> * Fix list indent Signed-off-by: Michał Górny <mgorny@quansight.com> * Uppercase RFC 2119 terms Signed-off-by: Michał Górny <mgorny@quansight.com> * Replace disjunction/conjunction with OR/AND Signed-off-by: Michał Górny <mgorny@quansight.com> * Add "untrusted" to "security considerations" Signed-off-by: Michał Górny <mgorny@quansight.com> * Move "summary of changes" to the rationale Pending further rewrite. Signed-off-by: Michał Górny <mgorny@quansight.com> * Shorten "Motivation" intro, move GROMACS example to "workarounds" Signed-off-by: Michał Górny <mgorny@quansight.com> * Move reused links to "references" section To make it easier to edit sections without having to move initial definitions around. Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove unnecessary project list from "limitations of ..." These additional projects are listed without any explanation, so let's just defer to specific examples in the "current workarounds ..." section. Signed-off-by: Michał Górny <mgorny@quansight.com> * Shorten limitations of platform tags Signed-off-by: Michał Górny <mgorny@quansight.com> * Change "... limitations" to "... drawbacks" in section title Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove solution bits from "motivation" Signed-off-by: Michał Górny <mgorny@quansight.com> * Simplify update problem explanation Signed-off-by: Michał Górny <mgorny@quansight.com> * Clarify CuPy Signed-off-by: Michał Górny <mgorny@quansight.com> * Combine paragraphs on extras Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove "motivation summary" This roughly repeats the introduction to motivation, and focuses on solution rather than the problem. Signed-off-by: Michał Górny <mgorny@quansight.com> * Add SLEAP quote Signed-off-by: Michał Górny <mgorny@quansight.com> * Move "out-of-scope features" to "rejected ideas" Signed-off-by: Michał Górny <mgorny@quansight.com> * Update cupy package list, and clarify Signed-off-by: Michał Górny <mgorny@quansight.com> * Revert "Move "out-of-scope features" to "rejected ideas"" This reverts commit 261704f. Signed-off-by: Michał Górny <mgorny@quansight.com> * Move glossary and overview into Rationale Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove speccy parts from "Overview" rationale Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove "summary of changes" for now Signed-off-by: Michał Górny <mgorny@quansight.com> * Highlight the added filename part Signed-off-by: Michał Górny <mgorny@quansight.com> * Avoid forward-linking from rationale to spec Signed-off-by: Michał Górny <mgorny@quansight.com> * Expand variant properties in rationale Signed-off-by: Michał Górny <mgorny@quansight.com> * Better explain providers in "Rationale" section Signed-off-by: Michał Górny <mgorny@quansight.com> * Readd info on using providers to the spec Signed-off-by: Michał Górny <mgorny@quansight.com> * Explain metadata a bit in rationale Signed-off-by: Michał Górny <mgorny@quansight.com> * Clarify provider part of spec Signed-off-by: Michał Górny <mgorny@quansight.com> * Explain ABI variant provider in the rationale Signed-off-by: Michał Górny <mgorny@quansight.com> * Rewording of confusing bits Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove duplicate "publishes builds" verb Signed-off-by: Michał Górny <mgorny@quansight.com> * Apply suggestions from code review Co-authored-by: Ralf Gommers <ralf.gommers@gmail.com> * project tree → source tree Signed-off-by: Michał Górny <mgorny@quansight.com> * regular wheel → non-variant wheel Signed-off-by: Michał Górny <mgorny@quansight.com> * Loosen and clarify verification at install time Signed-off-by: Michał Górny <mgorny@quansight.com> * Make respecting enable-if mandatory Signed-off-by: Michał Górny <mgorny@quansight.com> * Limit recommendations to install-time providers Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove "after verifying their trustworthiness" Signed-off-by: Michał Górny <mgorny@quansight.com> * Try to clarify build-time validation Signed-off-by: Michał Górny <mgorny@quansight.com> * Update links to where security is covered now Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove duplicate/non-spec content in Providers spec Signed-off-by: Michał Górny <mgorny@quansight.com> * Move environment and pinning bits to rationale Signed-off-by: Michał Górny <mgorny@quansight.com> * Mention metadata bits in overview Signed-off-by: Michał Górny <mgorny@quansight.com> * Remove some duplication in "Provider information" Environment marker usage and optionality is described in "Providers" section. Let's limit "Provider information" only to technical field details themselves. Signed-off-by: Michał Górny <mgorny@quansight.com> --------- Signed-off-by: Michał Górny <mgorny@quansight.com> Co-authored-by: Michał Górny <mgorny@quansight.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com> Co-authored-by: Ralf Gommers <ralf.gommers@gmail.com> Co-authored-by: Barry Warsaw <barry@python.org>
1 parent 9f61069 commit 62515a3

File tree

6 files changed

+2785
-0
lines changed

6 files changed

+2785
-0
lines changed

‎.github/CODEOWNERS‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -692,6 +692,8 @@ peps/pep-0811.rst @sethmlarson @gpshead
692692
peps/pep-0814.rst @vstinner @corona10
693693
peps/pep-0815.rst @emmatyping
694694
peps/pep-0816.rst @brettcannon
695+
peps/pep-0817.rst @warsaw @dstufft
696+
peps/pep-0817/ @warsaw @dstufft
695697
# ...
696698
peps/pep-0819.rst @emmatyping
697699
peps/pep-0820.rst @encukou

0 commit comments

Comments
 (0)