Skip to content

Commit 0dad4c3

Browse files
committed
Fix #2887: Sponsor logo collides with section header text
- Replaced 0fr with 1fr in the CSS Grid template for the sponsor listings to prevent overflow on wrapping. - Removed hardcoded 'grid-template-rows' logic that caused implicit rows to overlap. - Handled missing image logo metadata by resolving 'ValueError' in the 'ideal_size' sponsor templatetag.
1 parent ee7481b commit 0dad4c3

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

apps/sponsors/templates/sponsors/partials/sponsors-list.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@ <h3 class="widget-title">Job Board Sponsors</h3>
3636

3737
{% for package, placement_info in sponsorships_by_package.items %}
3838
{% if placement_info.sponsorships %}
39-
<div title="{{ package }} Sponsors" align="center">
39+
<div title="{{ package }} Sponsors" align="center" style="margin-bottom: 3em;">
4040
{% with dimension=placement_info.logo_dimension %}
4141

4242
<h1 style="font-size: {% if forloop.first %}350%{% else %}300%{% endif %}">{{ placement_info.label }} Sponsors</h1>
4343

44-
<div style="display: grid; grid-gap: 2em; grid-template-columns: repeat(auto-fit, minmax({{ dimension }}px, 0fr)); grid-template-rows: repeat(1, minmax({{ dimension }}px, 0fr)); align-items: center; justify-content: center;">
44+
<div style="display: grid; grid-gap: 2em; grid-template-columns: repeat(auto-fit, minmax({{ dimension }}px, 1fr)); align-items: center; justify-content: center;">
4545
{% for sponsorship in placement_info.sponsorships %}
4646
<div id="{{ sponsorship.sponsor.slug }}" data-internal-year={{ sponsorship.year }}>
4747
<div

apps/sponsors/templatetags/sponsors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def ideal_size(image, ideal_dimension):
8383
ideal_dimension = int(ideal_dimension)
8484
try:
8585
w, h = image.width, image.height
86-
except FileNotFoundError:
86+
except (FileNotFoundError, ValueError):
8787
# local dev doesn't have all images if DB is a copy from prod environment
8888
# this is just a fallback to return ideal_dimension instead
8989
w, h = ideal_dimension, ideal_dimension

0 commit comments

Comments
 (0)