Address Copilot review of format_html() functions (#2953)

Author: sethmlarson

apps/companies/tests.py

@@ -10,3 +10,7 @@ def test_render_email(self):
             render_email("firstname.lastname@domain.com"),
             "firstname<span>.</span>lastname<span>@</span>domain<span>.</span>com",
         )
+        self.assertEqual(
+            render_email('"escape.>me"@domain.com'),
+            "&quot;escape<span>.</span>&gt;me&quot;<span>@</span>domain<span>.</span>com",
+        )

apps/sponsors/admin.py

@@ -818,7 +818,7 @@ def get_custom_benefits_added_by_user(self, obj):
         if not benefits:
             return "---"
 
-        return format_html_join("", "<p>{}</p>", ((b,) for b in benefits))
+        return format_html_join("", "<p>{}</p>", [(benefit,) for benefit in benefits])
 
     @admin.display(description="Removed by User")
     def get_custom_benefits_removed_by_user(self, obj):
@@ -827,7 +827,7 @@ def get_custom_benefits_removed_by_user(self, obj):
         if not benefits:
             return "---"
 
-        return format_html_join("", "<p>{}</p>", ((b,) for b in benefits))
+        return format_html_join("", "<p>{}</p>", [(benefit,) for benefit in benefits])
 
     def rollback_to_editing_view(self, request, pk):
         """Delegate to the rollback_to_editing admin view."""
@@ -936,7 +936,7 @@ def other_years(self, obj):
 
             html += format_html(
                 dedent("""
-            <li><b>{year}</b>:"
+            <li><b>{year}</b>:
                 <ul>
                     <li><a target='_blank' href='{year_packages_url}'>List packages</a>
                     <li><a target='_blank' href='{year_benefits_url}'>List benefits</a>