address code review

Author: JacobCoffee

apps/sponsors/manage/views.py

@@ -836,9 +836,13 @@ def form_valid(self, form):
 
         if clone_benefits:
             for benefit in SponsorshipBenefit.objects.filter(year=source_year):
-                _, created = benefit.clone(target_year)
+                new_benefit, created = benefit.clone(target_year)
                 if created:
                     cloned_benefits += 1
+                    if not clone_packages:
+                        # benefit.clone() creates packages as a side effect;
+                        # clear them when packages weren't requested
+                        new_benefit.packages.clear()
 
         messages.success(
             self.request,