feat(#985): fix w3c validation (#2536)

* fix w3c validation: normalize aria roles, css decimals, and deprecated attributes

* revert treeitem role in tree containers where parent has role=tree

* add role=menu to subnav ul elements containing menuitem children

* remove role=menuitem from non-interactive empty placeholder list items

Author: JacobCoffee

apps/jobs/templates/jobs/base.html

@@ -26,36 +26,36 @@ <h1 class="call-to-action">{% block header_action %}{{ jobs_count }} jobs on the
         <a href="{% url 'jobs:job_types' %}">Types</a>
         <ul class="subnav menu" role="menu" aria-hidden="true">
             {% for t in active_types %}
-            <li class="tier-2" role="treeitem"><a href="{% url 'jobs:job_list_type' slug=t.slug %}">{{ t.name }}</a></li>
+            <li class="tier-2" role="menuitem"><a href="{% url 'jobs:job_list_type' slug=t.slug %}">{{ t.name }}</a></li>
             {% empty %}
-            <li class="tier-2" role="treeitem">No Active Types</li>
+            <li class="tier-2">No Active Types</li>
             {% endfor %}
         </ul>
     </li>
     <li class="tier-1 element-3 {% if view.job_category_view %}current_item selected{% endif %}" aria-haspopup="true">
         <a href="{% url 'jobs:job_categories' %}">Categories</a>
         <ul class="subnav menu" role="menu" aria-hidden="true">
             {% for c in active_categories %}
-            <li class="tier-2" role="treeitem"><a href="{% url 'jobs:job_list_category' slug=c.slug %}">{{ c.name }}</a></li>
+            <li class="tier-2" role="menuitem"><a href="{% url 'jobs:job_list_category' slug=c.slug %}">{{ c.name }}</a></li>
             {% empty %}
-            <li class="tier-2" role="treeitem">No Active Categories</li>
+            <li class="tier-2">No Active Categories</li>
             {% endfor %}
         </ul>
     </li>
     <li class="tier-1 element-4 {% if view.job_location_view %}current_item selected{% endif %}">
         <a href="{% url 'jobs:job_locations' %}">Locations</a>
         <ul class="subnav menu" role="menu" aria-hidden="true">
-            <li class="tier-2" role="treeitem"><a href="{% url 'jobs:job_telecommute' %}">Telecommute</a></li>
+            <li class="tier-2" role="menuitem"><a href="{% url 'jobs:job_telecommute' %}">Telecommute</a></li>
             {% for l in active_locations %}
-            <li class="tier-2" role="treeitem"><a href="{% url 'jobs:job_list_location' slug=l.location_slug %}">
+            <li class="tier-2" role="menuitem"><a href="{% url 'jobs:job_list_location' slug=l.location_slug %}">
                 {% if l.region and l.region != l.city %}
                     {{ l.city }}, {{ l.region }} &ndash; {{ l.country }}
                 {% else %}
                     {{ l.city }} &ndash; {{ l.country }}
                 {% endif %}
             </a></li>
             {% empty %}
-            <li class="tier-2" role="treeitem">No Active Locations</li>
+            <li class="tier-2">No Active Locations</li>
             {% endfor %}
         </ul>
     </li>
@@ -64,8 +64,8 @@ <h1 class="call-to-action">{% block header_action %}{{ jobs_count }} jobs on the
     <li class="tier-1 element-6 last">
         <a href="{% url 'jobs:job_review' %}">Admin</a>
         <ul class="subnav menu" role="menu" aria-hidden="true">
-            <li class="tier-2" role="treeitem"><a href="{% url 'jobs:job_review' %}">Review queue</a></li>
-            <li class="tier-2" role="treeitem"><a href="{% url 'jobs:job_moderate' %}">Moderate approved posts</a></li>
+            <li class="tier-2" role="menuitem"><a href="{% url 'jobs:job_review' %}">Review queue</a></li>
+            <li class="tier-2" role="menuitem"><a href="{% url 'jobs:job_moderate' %}">Moderate approved posts</a></li>
         </ul>
     </li>
     {% endif %}

apps/minutes/templates/minutes/minutes_detail.html

@@ -46,7 +46,7 @@ <h1>PSF Meeting Minutes for {{ minutes.date|date }}</h1>
         <h2>{{ minutes.date.year }}</h2>
         <ul class="section-nav menu" role="menu" aria-hidden="false">
             {% for item in same_year_minutes %}
-            <li class="tier-1 element-1" role="treeitem"><a href="{{ item.get_absolute_url }}">{{ item.date|date }}</a></li>
+            <li class="tier-1 element-1" role="menuitem"><a href="{{ item.get_absolute_url }}">{{ item.date|date }}</a></li>
             {% endfor %}
         </ul>