feat: asset browser with filters for type, owner, and submission status

Adds an asset browser under More > Assets that lists all sponsor and
sponsorship assets with filters for asset type (text, image, file,
response), related object (sponsor vs sponsorship), submission status
(submitted vs missing), and internal name search. Uses batch-loaded
lookups to avoid N+1 queries on generic relations.

Removes "Detailed asset filtering" from the admin-only guide section.
Includes 6 tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: JacobCoffee

apps/sponsors/manage/tests.py

@@ -24,6 +24,7 @@
     SponsorshipCurrentYear,
     SponsorshipPackage,
     SponsorshipProgram,
+    TextAsset,
 )
 
 
@@ -2459,3 +2460,54 @@ def test_move_down(self):
     def test_nav_has_legal_clauses_link(self):
         response = self.client.get(reverse("manage_dashboard"))
         self.assertContains(response, "Legal Clauses")
+
+
+class AssetBrowserViewTests(SponsorshipReviewTestBase):
+    """Test asset browser view."""
+
+    def _create_text_asset(self, content_object, internal_name, text=""):
+        """Helper to create a TextAsset via generic relation."""
+        from django.contrib.contenttypes.models import ContentType
+
+        ct = ContentType.objects.get_for_model(content_object)
+        return TextAsset.objects.create(
+            content_type=ct,
+            object_id=content_object.pk,
+            internal_name=internal_name,
+            text=text,
+        )
+
+    def test_browser_loads(self):
+        response = self.client.get(reverse("manage_assets"))
+        self.assertEqual(response.status_code, 200)
+
+    def test_browser_shows_assets(self):
+        self._create_text_asset(self.sponsor, "company_bio", text="Acme makes things")
+        response = self.client.get(reverse("manage_assets"))
+        self.assertContains(response, "company_bio")
+        self.assertContains(response, "Acme Corp")
+
+    def test_filter_by_value_with(self):
+        self._create_text_asset(self.sponsor, "filled_asset", text="Has value")
+        self._create_text_asset(self.sponsor, "empty_asset", text="")
+        response = self.client.get(reverse("manage_assets") + "?value=with")
+        self.assertContains(response, "filled_asset")
+        self.assertNotContains(response, "empty_asset")
+
+    def test_filter_by_value_without(self):
+        self._create_text_asset(self.sponsor, "filled_asset", text="Has value")
+        self._create_text_asset(self.sponsor, "empty_asset", text="")
+        response = self.client.get(reverse("manage_assets") + "?value=without")
+        self.assertNotContains(response, "filled_asset")
+        self.assertContains(response, "empty_asset")
+
+    def test_filter_by_search(self):
+        self._create_text_asset(self.sponsor, "logo_2025", text="logo")
+        self._create_text_asset(self.sponsor, "bio_text", text="bio")
+        response = self.client.get(reverse("manage_assets") + "?search=logo")
+        self.assertContains(response, "logo_2025")
+        self.assertNotContains(response, "bio_text")
+
+    def test_nav_has_assets_link(self):
+        response = self.client.get(reverse("manage_dashboard"))
+        self.assertContains(response, "Assets")

apps/sponsors/manage/urls.py

@@ -23,6 +23,8 @@
     path(
         "benefit-configs/<int:pk>/delete/", views.BenefitConfigDeleteView.as_view(), name="manage_benefit_config_delete"
     ),
+    # Asset browser
+    path("assets/", views.AssetBrowserView.as_view(), name="manage_assets"),
     # Legal clauses
     path("legal-clauses/", views.LegalClauseListView.as_view(), name="manage_legal_clauses"),
     path("legal-clauses/new/", views.LegalClauseCreateView.as_view(), name="manage_legal_clause_create"),

apps/sponsors/manage/views.py

@@ -48,6 +48,7 @@
     BenefitFeature,
     BenefitFeatureConfiguration,
     Contract,
+    GenericAsset,
     LegalClause,
     Sponsor,
     SponsorBenefit,
@@ -448,6 +449,80 @@ def post(self, request, pk):
         return redirect(reverse("manage_legal_clauses"))
 
 
+# ── Asset Browser ─────────────────────────────────────────────────────
+
+
+class AssetBrowserView(SponsorshipAdminRequiredMixin, TemplateView):
+    """Browse all sponsor/sponsorship assets with filters."""
+
+    template_name = "sponsors/manage/asset_browser.html"
+
+    def get_context_data(self, **kwargs):
+        """Return context with filtered assets and lookup caches."""
+        context = super().get_context_data(**kwargs)
+        from django.contrib.contenttypes.models import ContentType
+
+        qs = GenericAsset.objects.all_assets().select_related("content_type")
+
+        # Filters
+        self.filter_type = self.request.GET.get("type", "")
+        self.filter_related = self.request.GET.get("related", "")
+        self.filter_value = self.request.GET.get("value", "")
+        self.filter_search = self.request.GET.get("search", "")
+
+        if self.filter_type:
+            type_map = {cls.__name__: cls for cls in GenericAsset.all_asset_types()}
+            if self.filter_type in type_map:
+                qs = qs.instance_of(type_map[self.filter_type])
+
+        if self.filter_related:
+            with contextlib.suppress(ContentType.DoesNotExist, ValueError):
+                qs = qs.filter(content_type=ContentType.objects.get(pk=int(self.filter_related)))
+
+        if self.filter_search:
+            qs = qs.filter(internal_name__icontains=self.filter_search)
+
+        assets = list(qs[:200])
+
+        # Value filter (property-based, must be done in Python)
+        if self.filter_value == "with":
+            assets = [a for a in assets if a.has_value]
+        elif self.filter_value == "without":
+            assets = [a for a in assets if not a.has_value]
+
+        # Batch-load related objects to avoid N+1
+        sponsor_ids = {a.object_id for a in assets if a.from_sponsor}
+        sponsorship_ids = {a.object_id for a in assets if a.from_sponsorship}
+        sponsors_map = {s.pk: s for s in Sponsor.objects.filter(pk__in=sponsor_ids)} if sponsor_ids else {}
+        sponsorships_map = (
+            {s.pk: s for s in Sponsorship.objects.filter(pk__in=sponsorship_ids).select_related("sponsor", "package")}
+            if sponsorship_ids
+            else {}
+        )
+        for asset in assets:
+            if asset.from_sponsor:
+                asset.resolved_owner = sponsors_map.get(asset.object_id)
+                asset.owner_type = "sponsor"
+            else:
+                asset.resolved_owner = sponsorships_map.get(asset.object_id)
+                asset.owner_type = "sponsorship"
+
+        content_types = ContentType.objects.filter(model__in=["sponsor", "sponsorship"])
+        context.update(
+            {
+                "assets": assets,
+                "asset_count": len(assets),
+                "type_choices": [(cls.__name__, cls._meta.verbose_name) for cls in GenericAsset.all_asset_types()],
+                "content_type_choices": [(ct.pk, ct.model.title()) for ct in content_types],
+                "filter_type": self.filter_type,
+                "filter_related": self.filter_related,
+                "filter_value": self.filter_value,
+                "filter_search": self.filter_search,
+            }
+        )
+        return context
+
+
 class PackageListView(SponsorshipAdminRequiredMixin, ListView):
     """List sponsorship packages grouped by year."""
 

apps/sponsors/templates/sponsors/manage/_base.html

@@ -680,6 +680,7 @@
                 <a href="#" class="{% if active_tab == 'clone' or active_tab == 'guide' %}active{% endif %}" onclick="event.preventDefault();this.parentElement.classList.toggle('open');">More &#9662;</a>
                 <div class="manage-nav-dropdown">
                     <a href="{% url 'manage_legal_clauses' %}">Legal Clauses</a>
+                    <a href="{% url 'manage_assets' %}">Assets</a>
                     <a href="{% url 'manage_clone_year' %}">Clone Year</a>
                     <a href="{% url 'manage_guide' %}">Guide</a>
                 </div>

apps/sponsors/templates/sponsors/manage/asset_browser.html

@@ -0,0 +1,127 @@
+{% extends "sponsors/manage/_base.html" %}
+
+{% block page_title %}Assets | Sponsor Management{% endblock %}
+
+{% with active_tab="more" %}
+
+{% block manage_breadcrumbs %}
+<div class="manage-crumbs">
+    <a href="{% url 'manage_dashboard' %}">Dashboard</a>
+    <span class="sep">/</span>
+    <span class="current">Assets</span>
+</div>
+{% endblock %}
+
+{% block manage_content %}
+    <!-- Filter bar -->
+    <div class="manage-filter-bar" style="padding:12px 20px;">
+        <form method="get" style="display:flex;gap:10px;align-items:flex-end;flex-wrap:wrap;">
+            <div class="filter-field">
+                <select name="type" onchange="this.form.submit()">
+                    <option value="">All types</option>
+                    {% for val, label in type_choices %}
+                    <option value="{{ val }}" {% if val == filter_type %}selected{% endif %}>{{ label }}</option>
+                    {% endfor %}
+                </select>
+            </div>
+            <div class="filter-field">
+                <select name="related" onchange="this.form.submit()">
+                    <option value="">All objects</option>
+                    {% for val, label in content_type_choices %}
+                    <option value="{{ val }}" {% if val|slugify == filter_related %}selected{% endif %}>{{ label }}</option>
+                    {% endfor %}
+                </select>
+            </div>
+            <div class="filter-field">
+                <select name="value" onchange="this.form.submit()">
+                    <option value="">Any status</option>
+                    <option value="with" {% if filter_value == "with" %}selected{% endif %}>Submitted</option>
+                    <option value="without" {% if filter_value == "without" %}selected{% endif %}>Missing</option>
+                </select>
+            </div>
+            <div class="filter-field">
+                <input type="text" name="search" placeholder="Search internal name..." value="{{ filter_search }}" style="width:180px;">
+            </div>
+            <div class="filter-actions">
+                <button type="submit" class="btn btn-sm btn-secondary">Go</button>
+                {% if filter_type or filter_related or filter_value or filter_search %}
+                <a href="{% url 'manage_assets' %}" class="btn btn-sm btn-secondary">Clear</a>
+                {% endif %}
+            </div>
+            <div style="margin-left:auto;font-size:12px;color:#777;">
+                {{ asset_count }} asset{{ asset_count|pluralize }}{% if asset_count >= 200 %} (first 200){% endif %}
+            </div>
+        </form>
+    </div>
+
+    {% if assets %}
+    <table class="manage-table">
+        <thead>
+            <tr>
+                <th>Internal Name</th>
+                <th>Type</th>
+                <th>Belongs To</th>
+                <th>Owner</th>
+                <th style="text-align:center;">Status</th>
+                <th>Value</th>
+            </tr>
+        </thead>
+        <tbody>
+            {% for asset in assets %}
+            <tr>
+                <td style="font-weight:600;font-size:13px;">{{ asset.internal_name }}</td>
+                <td>
+                    <span class="tag tag-gray" style="font-size:10px;">{{ asset.polymorphic_ctype.name|title }}</span>
+                </td>
+                <td>
+                    {% if asset.owner_type == "sponsor" %}
+                    <span class="tag tag-blue" style="font-size:10px;">Sponsor</span>
+                    {% else %}
+                    <span class="tag tag-gold" style="font-size:10px;">Sponsorship</span>
+                    {% endif %}
+                </td>
+                <td style="font-size:13px;">
+                    {% if asset.resolved_owner %}
+                        {% if asset.owner_type == "sponsor" %}
+                        <a href="{% url 'manage_sponsor_edit' asset.resolved_owner.pk %}" style="color:#1a1a2e;text-decoration:none;">{{ asset.resolved_owner.name }}</a>
+                        {% else %}
+                        <a href="{% url 'manage_sponsorship_detail' asset.resolved_owner.pk %}" style="color:#1a1a2e;text-decoration:none;">
+                            {% if asset.resolved_owner.sponsor %}{{ asset.resolved_owner.sponsor.name }}{% else %}#{{ asset.resolved_owner.pk }}{% endif %}
+                            {% if asset.resolved_owner.package %}<span style="color:#999;font-size:11px;"> ({{ asset.resolved_owner.package.name }})</span>{% endif %}
+                        </a>
+                        {% endif %}
+                    {% else %}
+                    <span style="color:#ccc;">&mdash;</span>
+                    {% endif %}
+                </td>
+                <td style="text-align:center;">
+                    {% if asset.has_value %}
+                    <span class="tag tag-green" style="font-size:10px;">Submitted</span>
+                    {% else %}
+                    <span class="tag tag-red" style="font-size:10px;">Missing</span>
+                    {% endif %}
+                </td>
+                <td style="font-size:12px;color:#555;max-width:200px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap;">
+                    {% if asset.has_value %}
+                        {% if asset.is_file %}
+                        <a href="{{ asset.value.url }}" target="_blank" style="color:#3776ab;text-decoration:none;">{{ asset.value.name|truncatechars:40 }}</a>
+                        {% else %}
+                        {{ asset.value|truncatechars:60 }}
+                        {% endif %}
+                    {% else %}
+                    <span style="color:#ccc;">&mdash;</span>
+                    {% endif %}
+                </td>
+            </tr>
+            {% endfor %}
+        </tbody>
+    </table>
+    {% else %}
+    <div class="empty-state">
+        <div class="empty-icon">&#128193;</div>
+        <p>No assets match your filters.</p>
+    </div>
+    {% endif %}
+{% endblock %}
+
+{% endwith %}

apps/sponsors/templates/sponsors/manage/guide.html

@@ -339,7 +339,6 @@ <h3 style="font-size:16px;font-weight:700;color:#e74c3c;border-bottom:2px solid
 <li><strong>Benefit conflicts</strong> &mdash; configuring which benefits are mutually exclusive (M2M relationship in the admin)</li>
 <li><strong>Sponsorship program management</strong> &mdash; adding or editing programs (Foundation, PyCon, PyPI, etc.)</li>
 <li><strong>Advanced import/export</strong> &mdash; django-import-export for bulk data operations</li>
-<li><strong>Detailed asset filtering</strong> &mdash; filtering and administering individual uploaded assets across all sponsors</li>
 </ul>
 
 <div class="manage-alert manage-alert-info">