fix: handle release objects with 'invalid' names#2790
Conversation
|
The root cause that got us here was that I ticked "show on download page" for a PyManager release, which I shouldn't have done. https://github.com/python/pythondotorg/blob/main/downloads/managers.py#L16 would have filtered it out and we never would've hit this path. |
|
Not disagreeing with making the function not crash, to be clear. Maybe it's just as good to make |
|
whichever you prefer, or if it's just better to document/know that |
It never is! 😆 Let's at least make sure that checking the box doesn't bring down the site, and that unchecking it (which I have already done) fixes up any weird display on the page. Then we can rely on documentation from there, I think. |
|
@zooba does f809fd1 work for you? or did i misunderstand |
|
Yeah, that's the other approach I was thinking of. Both are fine, but I think the latter is a bit cleaner/safer over time. |
Description
/downloads/windowswhen trying to parse a non-standard relase object version