Add LocaleMiddleware to fix language chooser warning in tests#2877
Closed
njg7194 wants to merge 1 commit intopython:mainfrom
Closed
Add LocaleMiddleware to fix language chooser warning in tests#2877njg7194 wants to merge 1 commit intopython:mainfrom
njg7194 wants to merge 1 commit intopython:mainfrom
Conversation
This fixes the UserWarning about Language chooser requiring 'django.middleware.locale.LocaleMiddleware' in MIDDLEWARE. Fixes python#2742
Member
|
hey @njg7194 thanks for the PR. don't want to discourage you but since python.org is english-only, the simpler fix is setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
django.middleware.locale.LocaleMiddlewareto the MIDDLEWARE setting to resolve the warning that appears during test runs.Changes
LocaleMiddlewareafterSessionMiddlewareinpydotorg/settings/base.pyIssue
Fixes #2742
Context
The
admin_interfacepackage's language chooser feature requiresLocaleMiddlewareto be present in the MIDDLEWARE setting. Without it, a warning is raised:The middleware is placed after
SessionMiddlewareas per Django's documentation, which recommends it be positioned early, but after SessionMiddleware.