Skip to content

Allows windows-<VER>.json files to be added to pydotorg #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 5 commits into from
Jun 25, 2025
Merged

Allows windows-<VER>.json files to be added to pydotorg #255

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f438761
Allows windows-<VER>.json files to be added to pydotorg
zooba Jun 17, 2025
e7cc485
Merge branch 'master' into addjson
hugovk Jun 25, 2025
22879aa
Don't check for absent hyphen
hugovk Jun 25, 2025
028ff99
Add Windows release manifest to expected output
hugovk Jun 25, 2025
ec832ba
More verbose tests
hugovk Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,18 +271,12 @@
if rfile.endswith((".asc", ".sig", ".crt", ".sigstore", ".spdx.json")):
continue

for prefix in ("python", "Python"):
if rfile.startswith(prefix):
break
else:
prefix, _, rest = rfile.partition("-")

Check warning on line 274 in add_to_pydotorg.py

View check run for this annotation

Codecov / codecov/patch

add_to_pydotorg.py#L274 

Added line #L274 was not covered by tests

if prefix.lower() not in ("python-", "windows-"):

Check warning on line 276 in add_to_pydotorg.py

View check run for this annotation

Codecov / codecov/patch

add_to_pydotorg.py#L276 

Added line #L276 was not covered by tests
print(f" File {reldir}/{rfile} has wrong prefix")
continue

try:
prefix, rest = rfile.split("-", 1)
except: # noqa: E722
prefix, rest = rfile, ""

if not rest.startswith((release + "-", release + ".")):
print(f" File {reldir}/{rfile} has a different version")
continue
Expand Down
Loading