Skip to content

Correct type annotations on NetworkX DiGraphs #14595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 2 commits into from
Aug 20, 2025
Merged

Correct type annotations on NetworkX DiGraphs #14595

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd2e2c4
Correct type annotations on NetworkX NodeViews
charmoniumQ Aug 19, 2025
dbf1556
Make types more precise
charmoniumQ Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stubs/networkx/networkx/classes/digraph.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ class DiGraph(Graph[_Node]):
@cached_property
def in_edges(self) -> InEdgeView[_Node]: ...
@cached_property
def in_degree(self) -> int | InDegreeView[_Node] | InMultiDegreeView[_Node]: ...
def in_degree(self) -> InDegreeView[_Node] | InMultiDegreeView[_Node]: ...
@cached_property
def out_degree(self) -> int | OutDegreeView[_Node] | OutMultiDegreeView[_Node]: ...
def out_degree(self) -> OutDegreeView[_Node] | OutMultiDegreeView[_Node]: ...
Comment thread
charmoniumQ marked this conversation as resolved.
def to_undirected(self, reciprocal: bool = False, as_view: bool = False) -> Graph[_Node]: ... # type: ignore[override]
# reciprocal : If True, only edges that appear in both directions ... will be kept in the undirected graph.
def reverse(self, copy: bool = True) -> Self: ...
Expand Down
4 changes: 2 additions & 2 deletions stubs/networkx/networkx/classes/reportviews.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ class NodeView(Mapping[_Node, dict[str, Any]], AbstractSet[_Node]):
def __getitem__(self, n: _Node) -> dict[str, Any]: ...
def __contains__(self, n: object) -> bool: ...
@overload
def __call__(self, data: Literal[False] = False, default=None) -> Iterator[_Node]: ...
def __call__(self, data: Literal[False] = False, default=None) -> NodeView[_Node]: ...
Comment thread
charmoniumQ marked this conversation as resolved.
Outdated
@overload
def __call__(self, data: Literal[True] | str, default=None) -> Iterator[tuple[_Node, dict[str, Any]]]: ...
def __call__(self, data: Literal[True] | str, default=None) -> NodeDataView[_Node]: ...
def data(self, data: bool | str = True, default=None) -> NodeDataView[_Node]: ...

class NodeDataView(AbstractSet[_Node]):
Expand Down