Skip to content

PyMySQL: added stub for SSCursor.readnext#14670

Merged
brianschubert merged 8 commits into
python:mainfrom
Spider84pr:devel
Sep 8, 2025
Merged

PyMySQL: added stub for SSCursor.readnext#14670
brianschubert merged 8 commits into
python:mainfrom
Spider84pr:devel

Conversation

@Spider84pr
Copy link
Copy Markdown
Contributor

I have added stub for one function.
This is my first pull request - sorry if something wrong

@github-actions

This comment has been minimized.

@srittau
Copy link
Copy Markdown
Collaborator

srittau commented Sep 3, 2025

Looking at the source code, shouldn't this return tuple[Any, ...] (i.e. the normal row type used in SSCursor? And SSDictCursor.SSDictCursor should return dict[str, Any], since it's deriving from DictCursorMixin?

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Spider84pr
Copy link
Copy Markdown
Contributor Author

I am very sorry.
While waiting your anwer decided to work on another annotation and added commit in wrong pull request.
Can you help me solve me this problem?
SOrry I am lacking expirience and unaable revert it

@brianschubert
Copy link
Copy Markdown
Collaborator

Running git revert --no-edit HEAD on the command line should do the trick. That will create a new commit that "undoes" the last commit.

@Spider84pr
Copy link
Copy Markdown
Contributor Author

Running git revert --no-edit HEAD on the command line should do the trick. That will create a new commit that "undoes" the last commit.

THank for advice but I am afraid to do something bad or illegal - I think better wait @srittau

@sobolevn
Copy link
Copy Markdown
Member

sobolevn commented Sep 8, 2025

@brianschubert's comment seems correct :)

@github-actions

This comment has been minimized.

Comment thread stubs/PyMySQL/pymysql/cursors.pyi
Comment thread stubs/PyMySQL/pymysql/cursors.pyi Outdated
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 8, 2025

Diff from mypy_primer, showing the effect of this PR on open source code:

discord.py (https://github.com/Rapptz/discord.py)
- discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "description", "name"  [misc]
+ discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "name", "description"  [misc]
- discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "description", "name"  [misc]
+ discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "name", "description"  [misc]

@Spider84pr
Copy link
Copy Markdown
Contributor Author

Spider84pr commented Sep 8, 2025

@brianschubert maybe I should to add more stubs?

@brianschubert
Copy link
Copy Markdown
Collaborator

Thanks!

@brianschubert brianschubert merged commit de81998 into python:main Sep 8, 2025
48 checks passed
@Spider84pr Spider84pr deleted the devel branch October 1, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants