PyMySQL: added stub for SSCursor.readnext#14670
Conversation
This comment has been minimized.
This comment has been minimized.
|
Looking at the source code, shouldn't this return |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I am very sorry. |
|
Running |
THank for advice but I am afraid to do something bad or illegal - I think better wait @srittau |
|
@brianschubert's comment seems correct :) |
This reverts commit 99edffd.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
|
Diff from mypy_primer, showing the effect of this PR on open source code: discord.py (https://github.com/Rapptz/discord.py)
- discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "description", "name" [misc]
+ discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "name", "description" [misc]
- discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "description", "name" [misc]
+ discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "name", "description" [misc]
|
|
@brianschubert maybe I should to add more stubs? |
|
Thanks! |
I have added stub for one function.
This is my first pull request - sorry if something wrong