[xmltodict] stub improvements and update to 1.0#14695
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Marking this as draft as it looks like upstream is about to make a new release that changes some types |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- Closes: python#14710 - Add default values - Reveal kwargs - Add to stricter pyright exclude list
This comment has been minimized.
This comment has been minimized.
|
Ready for review as xmltodict 1.0 is released and I included it with a merge from @donbarbos |
This comment has been minimized.
This comment has been minimized.
srittau
left a comment
There was a problem hiding this comment.
Thanks! (I'm fine with including the internal class as well.) One question and two remarks below.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@tapple-cisco I've merged @donbarbos's PR first to have the correct author information in the repository. Unfortunately, it seems that xmltodict 1.0.1 removed the |
I did that before your merge 7f54a8f and I repeated it: 78d836a c11a3ef |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Sebastian Rittau <sebastian.rittau@zfutura.de>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
_DictSAXHandler