Skip to content

[xmltodict] stub improvements and update to 1.0#14695

Merged
srittau merged 17 commits into
python:mainfrom
tapple-cisco:xmltodict
Sep 19, 2025
Merged

[xmltodict] stub improvements and update to 1.0#14695
srittau merged 17 commits into
python:mainfrom
tapple-cisco:xmltodict

Conversation

@tapple-cisco

@tapple-cisco tapple-cisco commented Sep 11, 2025

Copy link
Copy Markdown
Contributor

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Comment thread stubs/xmltodict/xmltodict.pyi
@tapple-cisco tapple-cisco marked this pull request as ready for review September 11, 2025 20:57
@github-actions

This comment has been minimized.

@tapple-cisco

Copy link
Copy Markdown
Contributor Author

Marking this as draft as it looks like upstream is about to make a new release that changes some types

@tapple-cisco tapple-cisco marked this pull request as draft September 12, 2025 14:31
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

- Closes: python#14710
- Add default values
- Reveal kwargs
- Add to stricter pyright exclude list
@tapple-cisco tapple-cisco marked this pull request as ready for review September 15, 2025 13:37
@tapple-cisco tapple-cisco changed the title xmltodict stub improvements xmltodict stub improvements and bump to 1.0 Sep 15, 2025
@github-actions

This comment has been minimized.

@tapple-cisco

Copy link
Copy Markdown
Contributor Author

Ready for review as xmltodict 1.0 is released and I included it with a merge from @donbarbos

@tapple-cisco tapple-cisco changed the title xmltodict stub improvements and bump to 1.0 [xmltodict] stub improvements and update to 1.0 Sep 15, 2025
Comment thread pyrightconfig.stricter.json
@github-actions

This comment has been minimized.

@srittau srittau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (I'm fine with including the internal class as well.) One question and two remarks below.

Comment thread stubs/xmltodict/xmltodict.pyi Outdated
Comment thread stubs/xmltodict/xmltodict.pyi
Comment thread stubs/xmltodict/xmltodict.pyi
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@srittau

srittau commented Sep 19, 2025

Copy link
Copy Markdown
Collaborator

@tapple-cisco I've merged @donbarbos's PR first to have the correct author information in the repository. Unfortunately, it seems that xmltodict 1.0.1 removed the __author__, __version__, and __license__ fields. Could you remove them and update the version field to ~= 1.0.1?

@tapple-cisco

Copy link
Copy Markdown
Contributor Author

@tapple-cisco I've merged @donbarbos's PR first to have the correct author information in the repository. Unfortunately, it seems that xmltodict 1.0.1 removed the __author__, __version__, and __license__ fields. Could you remove them and update the version field to ~= 1.0.1?

I did that before your merge 7f54a8f and I repeated it: 78d836a c11a3ef

@github-actions

This comment has been minimized.

Comment thread stubs/xmltodict/METADATA.toml Outdated
Co-authored-by: Sebastian Rittau <sebastian.rittau@zfutura.de>
@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 15bc02e into python:main Sep 19, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants