[tkinter] Remove a few type aliases#14742
Merged
Akuli merged 6 commits intopython:mainfrom Sep 23, 2025
Merged
Conversation
Inspired by python#14631 (comment) I only got rid of some of the aliases (the simplest ones) to make sure that others supported this action and to test the functionality of this idea.
This comment has been minimized.
This comment has been minimized.
Akuli
reviewed
Sep 18, 2025
Collaborator
Akuli
left a comment
Akuli
left a comment
There was a problem hiding this comment.
Thanks!
A few thoughts, mostly about _ScreenUnits. Perhaps we could split the _ScreenUnits stuff into yet another PR? :)
At first I was worried about backwards compatibility in ttkthemes, but then I realized that there is no problem. Standard library stubs are usually updated much later than third-party stubs, and if you use the new ttkthemes stubs with older stdlib tkinter stubs, the new ttkthemes stubs will work.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Akuli
changed the title
Akuli
approved these changes
Sep 23, 2025
Collaborator
Akuli
left a comment
Akuli
left a comment
There was a problem hiding this comment.
This is great, thanks!
Also, sorry about asking you to split your changes multiple times. As usual, tkinter is surprisingly tricky :)
donbarbos
added a commit
to donbarbos/typeshed
that referenced
this pull request
Sep 25, 2025
Akuli
pushed a commit
that referenced
this pull request
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #14631 (comment)
I only got rid of some of the aliases (the simplest ones) to make sure that others supported this action and to test the functionality of this idea.