[curses] Revert Final for LINES and COLS#14764
Merged
srittau merged 1 commit intopython:mainfrom Sep 23, 2025
Merged
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Collaborator
|
LGTM, is there anything missing? |
Contributor
Author
No, I'm just not sure about |
Collaborator
We can always change it if someone complains. |
srittau
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the values can be changed in one runtime, for example during a terminal resize, then this doesn't really fit the concept of
Final, although I honestly haven't found an exact definition in PEP when changing value of object is no longer permissible forFinal(Is it normal to have different values for different builds, python runtimes, subinterpreters, or other?)Docs: https://docs.python.org/dev/library/curses.html#curses.COLORS
Inspired by #14613 (comment)