fixed: reportlab - incorrect type on function parameter#14777
Merged
srittau merged 3 commits intopython:mainfrom Sep 25, 2025
Merged
fixed: reportlab - incorrect type on function parameter#14777srittau merged 3 commits intopython:mainfrom
srittau merged 3 commits intopython:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Daverball
reviewed
Sep 25, 2025
Contributor
There was a problem hiding this comment.
Thanks for your contribution. As discussed in the issue, this change should be good.
A tighter protocol would be better, but it's difficult to analyze how tight we can make it without violating some invariant in the huge reportlab codebase somewhere, so this should be fine for now.
I can't merge your PR, so you'll have to wait for one of the maintainers to see this.
srittau
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14518