Add explicit definition for __repr__ and __str__ in BaseException#14900
Merged
AlexWaygood merged 1 commit intopython:mainfrom Oct 20, 2025
Merged
Add explicit definition for __repr__ and __str__ in BaseException#14900AlexWaygood merged 1 commit intopython:mainfrom
AlexWaygood merged 1 commit intopython:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Oct 20, 2025
Taint analysis tools such as Pysa might want to mark `BaseException.__str__` and `BaseException.__repr__` as a source. However, since those methods are inherited, this is not possible. Making the definition explicit fixes the problem.
AlexWaygood
approved these changes
Oct 20, 2025
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks, this seems fine to me
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taint analysis tools such as Pysa might want to mark
BaseException.__str__andBaseException.__repr__as a source and check if it flows to a sink (such as a logging call). Leaking exception messages is usually a security risk.However, since those methods are inherited from
object, marking those as sources does not work.This can be easily fixed by making the definition explicit, which this PR does.
I agree this is not optimal, but the alternatives are limited: