Annotate braintree's Subscription and Transaction methods#14917
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
donbarbos
approved these changes
Oct 24, 2025
donbarbos
left a comment
donbarbos
left a comment
Contributor
There was a problem hiding this comment.
Thank you!
I think we could also annotate SubscriptionGateway.find, TransactionGateway.find methods that are called inside the methods you already annotated :-)
Contributor
Author
|
@donbarbos thanks, makes sense, updated the PR. |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@donbarbos a quick question – I'd like to get a few more braintree type annotations in. Would it be better to submit them in piecemeal PRs or in a one bigger PR? Thanks! |
Contributor
|
This isn't a fundamental issue, as typeshed will always be glad to receive your contributions in any form. (I'm not a maintainer) but I think the preferred method is separate commits for easier review. |
cuu508
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.