Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
I'm not sure why primer keeps complaining about pandas in every PR, but it's unrelated. |
Member
|
yeah, looks like some mypy nondeterminism -- maybe new in mypy 1.20.0? |
AlexWaygood
approved these changes
Apr 8, 2026
| # and earlier. For compatibility reasons, we don't allow None in the stubs. | ||
| os.posix_spawn | ||
| os.posix_spawnp | ||
|
|
Member
There was a problem hiding this comment.
I support this. When we add support for 3.15, we should probably allow None for the parameter in a sys.version_info >= (3, 15) branch rather than adding another allowlist entry, though. (We could maybe do that now, so we don't forget?)
Collaborator
Author
There was a problem hiding this comment.
Hah, I was actually deliberating myself whether we should already add the 3.15 branch, but decided against it due to our general policy. But if you had the same idea, I think it makes sense to add it.
AlexWaygood
approved these changes
Apr 8, 2026
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pandas (https://github.com/pandas-dev/pandas)
+ pandas/core/computation/ops.py:328: error: Need type annotation for "_binary_ops_dict" (hint: "_binary_ops_dict: dict[<type>, <type>] = ...") [var-annotated]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.