Fix flaky hnswlib stubtest allowlist - #16102
Open
nightcityblade wants to merge 2 commits into
Open
Conversation
Author
|
Addressed the Linux stubtest failure in 8e76d4e. The PR job reproduced the Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16100
The daily Linux job did not report the
hnswlib.Indexmetaclass mismatch and therefore rejected the existing allowlist entry as unused, while the PR's fresh Linux job reproduced the mismatch. Keep the exception cross-platform, but make the regular-expression entry optional so stubtest accepts both runtime variants.Tests:
PYTHONPATH=lib python3 tests/stubtest_third_party.py hnswlib -vPYTHONPATH=lib python3 tests/check_typeshed_structure.pyuvx pre-commit run --files stubs/hnswlib/@tests/stubtest_allowlist.txt