Skip to content

Add disclaimer to conformance results #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 3 commits into from
Jan 22, 2026
Merged

Add disclaimer to conformance results #2155

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39f3dd0
Add disclaimer to conformance results
hauntsaninja Jan 20, 2026
36a9e0e
.
hauntsaninja Jan 21, 2026
c07bfea
oops
hauntsaninja Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion conformance/results/results.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
background-color: #333;
color: #fff;
text-align: center;
padding: 8px;
padding: 10px 16px 12px;
}

table {
Expand Down Expand Up @@ -148,13 +148,27 @@
.hover-text {
position: relative;
}

.disclaimer {
margin: 6px auto 0;
max-width: 720px;
font-size: 12px;
line-height: 1.4;
font-weight: normal;
color: #d6d6d6;
}
</style>
</head>

<body>
<div class="content_container">
<header>
<h3>Python Type System Conformance Test Results</h3>
<p class="disclaimer">
While spec conformance is important for the ecosystem, we don't recommend using it
as the primary basis for choosing a type checker. It is not (and is not meant to be)
representative of the things users typically care about.
</p>
</header>
<div class="table_container"><table><tbody>
<tr><th class="col1">&nbsp;</th>
Expand Down
16 changes: 15 additions & 1 deletion conformance/src/results_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
background-color: #333;
color: #fff;
text-align: center;
padding: 8px;
padding: 10px 16px 12px;
}

table {
Expand Down Expand Up @@ -148,13 +148,27 @@
.hover-text {
position: relative;
}

.disclaimer {
margin: 6px auto 0;
max-width: 720px;
font-size: 12px;
line-height: 1.4;
font-weight: normal;
color: #d6d6d6;
}
</style>
</head>

<body>
<div class="content_container">
<header>
<h3>Python Type System Conformance Test Results</h3>
<p class="disclaimer">
While spec conformance is important for the ecosystem, we don't recommend using it
as the primary basis for choosing a type checker. It is not (and is not meant to be)
Copy link
Copy Markdown
Member

@JelleZijlstra JelleZijlstra Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This second sentence feels a bit too strong for me. Sure, a lot of the conformance suite is about esoteric topics that don't affect users much, and there are many important aspects of a practical type checker that aren't reflected in the conformance suite, but I do believe that spec conformant behavior should be user-friendly behavior.

Copy link
Copy Markdown
Collaborator Author

@hauntsaninja hauntsaninja Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, tried a reword

representative of the things users typically care about.
</p>
</header>
{{summary}}
<!-- <div>
Expand Down