Skip to content

Fix incorrect type name in TypedDict extra_items assignment test #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carljm merged 2 commits into from
Feb 21, 2026
Merged

Fix incorrect type name in TypedDict extra_items assignment test #2184

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e899a4
Fix incorrect type name in TypedDict extra_items assignment test
azimsh3r Feb 20, 2026
2803975
Apply suggestion from @JelleZijlstra
JelleZijlstra Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conformance/tests/typeddicts_extra_items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class MovieWithYear2(TypedDict, extra_items=int | None):
year: int | None

details3: MovieWithYear2 = {"name": "Kill Bill Vol. 1", "year": 2003}
movie3: MovieBase2 = details3 # E:'year' is not required in 'Movie', but it is required in 'MovieWithYear2'
movie3: MovieBase2 = details3 # E:'year' is not required in 'MovieBase2', but it is required in 'MovieWithYear2'
Comment thread
JelleZijlstra marked this conversation as resolved.
Outdated

# > When ``extra_items`` is specified to be read-only on a TypedDict type, it is
# > possible for an item to have a :term:`narrower <narrow>` type than the
Expand Down