Skip to content

Add back _AnnotatedAlias #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 1 commit into from
Apr 17, 2025
Merged

Add back _AnnotatedAlias #587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/test_typing_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5251,6 +5251,11 @@ def test_nested_annotated_with_unhashable_metadata(self):
self.assertEqual(X.__origin__, List[Annotated[str, {"unhashable_metadata"}]])
self.assertEqual(X.__metadata__, ("metadata",))

def test_compatibility(self):
# Test that the _AnnotatedAlias compatibility alias works
self.assertTrue(hasattr(typing_extensions, "_AnnotatedAlias"))
self.assertIs(typing_extensions._AnnotatedAlias, typing._AnnotatedAlias)


class GetTypeHintsTests(BaseTestCase):
def test_get_type_hints(self):
Expand Down
5 changes: 4 additions & 1 deletion src/typing_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4095,7 +4095,7 @@ def evaluate_forward_ref(
)


# Aliases for items that have always been in typing.
# Aliases for items that are in typing in all supported versions.
Copy link
Copy Markdown
Member Author

@JelleZijlstra JelleZijlstra Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but this statement wasn't accurate any more

# Explicitly assign these (rather than using `from typing import *` at the top),
# so that we get a CI error if one of these is deleted from typing.py
# in a future version of Python
Expand Down Expand Up @@ -4136,3 +4136,6 @@ def evaluate_forward_ref(
cast = typing.cast
no_type_check = typing.no_type_check
no_type_check_decorator = typing.no_type_check_decorator
# This is private, but it was defined by typing_extensions for a long time
# and some users rely on it.
_AnnotatedAlias = typing._AnnotatedAlias
Loading