Skip to content

Upgrade ruff version and rules #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 9 commits into from
Jul 8, 2025
Merged

Upgrade ruff version and rules #629

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a5f1694
Upgrade ruff to 0.10.0
Daraan Mar 14, 2025
9018936
Prefer not to use 0.10
Daraan Mar 26, 2025
6e57223
Merge remote-tracking branch 'upstream' into upgrade-ruff
Daraan Jul 8, 2025
c615c2e
Upgrade ruff
Daraan Jul 8, 2025
6b72619
Upgrade ruff to 0.12.2
Daraan Jul 8, 2025
6c9eeec
Feedback: Disable autofix, per-file-ignores
Daraan Jul 8, 2025
6b928db
Merge remote-tracking branch 'origin/upgrade-ruff' into upgrade-ruff
Daraan Jul 8, 2025
218f33c
Feedback
Daraan Jul 8, 2025
9d96d50
Merge branch 'main' into upgrade-ruff
Daraan Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.9.6
rev: v0.12.2
hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix]
Comment thread
AlexWaygood marked this conversation as resolved.
Outdated
Expand Down
12 changes: 8 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,14 @@ ignore = [
"UP019",
"UP035",
"UP038",
# Not relevant here
"RUF012",
"RUF022",
"RUF023",
# Not relevant here, or harmful for tests if applied.
"RUF012", # Use ClassVar for mutables
"RUF022", # Unsorted __all__
"RUF023", # Unsorted __slots__
"RUF031", # parentheses for tuples in subscripts
"RUF041", # nested Literal
"RUF036", # None not at end of Union
Comment thread
AlexWaygood marked this conversation as resolved.
Outdated
"B903", # Use dataclass / namedtuple
# Ruff doesn't understand the globals() assignment; we test __all__
# directly in test_all_names_in___all__.
"F822",
Expand Down
2 changes: 1 addition & 1 deletion src/_typed_dict_test_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class Foo(TypedDict):


class FooGeneric(TypedDict, Generic[T]):
a: Optional[T]
a: Optional[T] # noqa: UP045 while < (3, 10)
Comment thread
AlexWaygood marked this conversation as resolved.
Outdated


class VeryAnnotated(TypedDict, total=False):
Expand Down
Loading