Typing fixes, backends package is excluded from typing for now

Author: Cleptomania

arcade/gl/context.py

@@ -859,7 +859,7 @@ def texture(
         filter=None,
         samples: int = 0,
         immutable: bool = False,
-        internal_format,
+        internal_format=None,
         compressed: bool = False,
         compressed_data: bool = False,
     ) -> Texture2D:

arcade/gl/provider.py

@@ -7,7 +7,7 @@
 if TYPE_CHECKING:
     from arcade.context import ArcadeContext
 
-    from .context import Context
+    from .context import Context, Info
 
 _current_provider: Optional[BaseProvider] = None
 
@@ -31,13 +31,17 @@ def get_context(*args, **kwargs) -> Context:
     if _current_provider is None:
         set_provider("opengl")
 
+    assert _current_provider is not None  # this can't really be None at this point, but mypy
+
     return _current_provider.create_context(*args, **kwargs)
 
 
 def get_arcade_context(*args, **kwargs) -> ArcadeContext:
     if _current_provider is None:
         set_provider("opengl")
 
+    assert _current_provider is not None  # this can't really be None at this point, but mypy
+
     return _current_provider.create_arcade_context(*args, **kwargs)
 
 
@@ -47,7 +51,7 @@ def create_context(self, *args, **kwargs) -> Context:
         pass
 
     @abstractmethod
-    def create_info(self, ctx: Context):
+    def create_info(self, ctx: Context) -> Info:
         pass
 
     @abstractmethod

arcade/gl/sampler.py

@@ -30,9 +30,9 @@ def __init__(
         # We're creating them here first to trick some of the methods on the
         # base class to being able to see them. So that we don't have to
         # implement a getter on every backend
-        self._filter = None
-        self._wrap_x = None
-        self._wrap_y = None
+        self._filter = (0, 0)  # Mypy needs this to be a tuple[int, int] to be happy
+        self._wrap_x = 0  # Mypy needs this to be an int to be happy
+        self._wrap_y = 0  # Mypy needs this to be an int to be happy
 
         self.texture = texture
 

arcade/gl/texture.py

@@ -132,6 +132,12 @@ def __init__(
         self._compressed = compressed
         self._compressed_data = compressed_data
 
+        # _filter ultimately need to be set by the implementing backend.
+        # We're creating it here first to trick some of the methods on the
+        # base class to being able to see it. So that we don't have to
+        # implement a getter on every backend
+        self._filter = (0, 0)  # Mypy needs this to be a tuple[int, int] to be happy
+
         self._wrap_x = enums.REPEAT
         self._wrap_y = enums.REPEAT
 

arcade/gl/texture_array.py

@@ -133,6 +133,14 @@ def __init__(
         self._compressed = compressed
         self._compressed_data = compressed_data
 
+        # These three ultimately need to be set by the implementing backend.
+        # We're creating them here first to trick some of the methods on the
+        # base class to being able to see them. So that we don't have to
+        # implement a getter on every backend
+        self._filter = (0, 0)  # Mypy needs this to be a tuple[int, int] to be happy
+        self._wrap_x = 0  # Mypy needs this to be an int to be happy
+        self._wrap_y = 0  # Mypy needs this to be an int to be happy
+
         if self._components not in [1, 2, 3, 4]:
             raise ValueError("Components must be 1, 2, 3 or 4")
 

arcade/management/__init__.py

@@ -28,7 +28,11 @@ def show_info():
     print("-" * len(version_str))
     print("vendor:", window.ctx.info.VENDOR)
     print("renderer:", window.ctx.info.RENDERER)
-    print("version:", window.ctx.gl_version)
+    # TODO: Abstracted GL backend
+    # The context doesn't necessarily have this, this will need changed later
+    # Probably the context needs to provide an info function that will spit back relevent stuff
+    # rather than hardcoding the things we want here
+    print("version:", window.ctx.gl_version)  # type: ignore
     print("python:", sys.version)
     print("platform:", sys.platform)
     print("pyglet version:", pyglet.version)

pyproject.toml

@@ -125,6 +125,9 @@ exclude = ["arcade/examples/*", "benchmarks/*"]
 
 [tool.mypy]
 disable_error_code = "annotation-unchecked"
+exclude = [
+    "arcade/gl/backends"
+]
 
 [tool.pytest.ini_options]
 norecursedirs = [
@@ -149,6 +152,7 @@ exclude = [
     "arcade/__pyinstaller",
     "arcade/examples",
     "arcade/experimental",
+    "arcade/gl/backends",
     "tests",
     "doc",
     "make.py",