Address review feedback: use Ellipsis sentinel, add type hints, use catch_warnings in tests

Co-authored-by: eruvanos <9437863+eruvanos@users.noreply.github.com>

Author: Copilot

arcade/gui/widgets/layout.py

@@ -14,7 +14,7 @@
 
 W = TypeVar("W", bound="UIWidget")
 
-_NO_EXPLICIT_SIZE = object()
+_NO_EXPLICIT_SIZE = ...
 """Sentinel value to detect when width/height was not explicitly provided by the user."""
 
 
@@ -31,9 +31,9 @@ def _warn_if_size_hint_overrides_fixed_size(
 
     Args:
         class_name: Name of the layout class, used in the warning message.
-        width: The width argument passed to __init__, or ``_NO_EXPLICIT_SIZE`` if
+        width: The width argument passed to __init__, or ``...`` if
             width was not explicitly provided.
-        height: The height argument passed to __init__, or ``_NO_EXPLICIT_SIZE`` if
+        height: The height argument passed to __init__, or ``...`` if
             height was not explicitly provided.
         size_hint: The size_hint argument passed to __init__.
     """
@@ -114,8 +114,8 @@ def __init__(
         *,
         x: float = 0,
         y: float = 0,
-        width: float = _NO_EXPLICIT_SIZE,
-        height: float = _NO_EXPLICIT_SIZE,
+        width: float | type(...) = _NO_EXPLICIT_SIZE,
+        height: float | type(...) = _NO_EXPLICIT_SIZE,
         children: Iterable[UIWidget] = tuple(),
         size_hint=(1, 1),
         size_hint_min=None,

tests/unit/gui/test_layout_size_hint_warning.py

@@ -1,4 +1,6 @@
 """Tests that layouts warn when explicit width/height conflicts with active size_hint."""
+import warnings
+
 import pytest
 
 from arcade.gui import UIBoxLayout
@@ -19,14 +21,16 @@ def test_anchor_layout_warns_when_height_given_with_default_size_hint(window):
 
 def test_anchor_layout_no_warning_when_size_hint_none(window):
     """UIAnchorLayout should not warn when size_hint=None is explicitly set."""
-    # No warning expected
-    UIAnchorLayout(width=500, height=500, size_hint=None)
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
+        UIAnchorLayout(width=500, height=500, size_hint=None)
 
 
 def test_anchor_layout_no_warning_when_no_explicit_size(window):
     """UIAnchorLayout should not warn when width/height are not explicitly given."""
-    # No warning expected
-    UIAnchorLayout(size_hint=(1, 1))
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
+        UIAnchorLayout(size_hint=(1, 1))
 
 
 def test_anchor_layout_no_warning_when_size_hint_x_none(window):
@@ -57,14 +61,16 @@ def test_box_layout_warns_when_height_given_with_default_size_hint(window):
 
 def test_box_layout_no_warning_when_size_hint_none(window):
     """UIBoxLayout should not warn when size_hint=None is explicitly set."""
-    # No warning expected
-    UIBoxLayout(width=200, height=200, size_hint=None)
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
+        UIBoxLayout(width=200, height=200, size_hint=None)
 
 
 def test_box_layout_no_warning_when_no_explicit_size(window):
     """UIBoxLayout should not warn when width/height are not explicitly given."""
-    # No warning expected
-    UIBoxLayout(size_hint=(0, 0))
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
+        UIBoxLayout(size_hint=(0, 0))
 
 
 def test_grid_layout_warns_when_width_given_with_default_size_hint(window):
@@ -81,14 +87,16 @@ def test_grid_layout_warns_when_height_given_with_default_size_hint(window):
 
 def test_grid_layout_no_warning_when_size_hint_none(window):
     """UIGridLayout should not warn when size_hint=None is explicitly set."""
-    # No warning expected
-    UIGridLayout(width=200, height=200, size_hint=None)
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
+        UIGridLayout(width=200, height=200, size_hint=None)
 
 
 def test_grid_layout_no_warning_when_no_explicit_size(window):
     """UIGridLayout should not warn when width/height are not explicitly given."""
-    # No warning expected
-    UIGridLayout(size_hint=(0, 0))
+    with warnings.catch_warnings():
+        warnings.simplefilter("error")
+        UIGridLayout(size_hint=(0, 0))
 
 
 def test_warning_message_includes_class_name(window):