ci: error handling

Author: pythoninthegrass

.github/workflows/release-please.yml

@@ -32,32 +32,57 @@ jobs:
           config-file: release-please-config.json
           manifest-file: .release-please-manifest.json
 
+  download-artifacts:
+    needs: release-please
+    if: needs.release-please.outputs.release_created == 'true'
+    runs-on: ubuntu-latest
+    outputs:
+      artifacts_found: ${{ steps.check-artifacts.outputs.artifacts_found }}
+
+    steps:
       - name: Download workflow artifacts
         uses: dawidd6/action-download-artifact@v6
         with:
           workflow: build.yml
           workflow_conclusion: success
           branch: ${{ github.event_name == 'push' && github.ref_name || github.event.workflow_run.head_branch }}
           path: artifacts
-          if_no_artifact_found: fail
+          if_no_artifact_found: warn
 
-      - name: Wait for assets to be created
-        id: wait-for-assets
+      - name: Check for artifacts
+        id: check-artifacts
         run: |
-          while [ ! -d "artifacts" ] || [ -z "$(ls -A artifacts)" ]; do
-            echo "Waiting for assets to be created..."
-            sleep 10
-          done
+          if [ -d "artifacts" ] && [ "$(ls -A artifacts)" ]; then
+            echo "artifacts_found=true" >> $GITHUB_OUTPUT
+          else
+            echo "artifacts_found=false" >> $GITHUB_OUTPUT
+          fi
+
+      - name: Upload artifacts
+        uses: actions/upload-artifact@v3
+        if: steps.check-artifacts.outputs.artifacts_found == 'true'
+        with:
+          name: release-artifacts
+          path: artifacts
+
+  upload-release-assets:
+    needs: [release-please, download-artifacts]
+    if: >
+      needs.release-please.outputs.release_created == 'true' &&
+      needs.download-artifacts.outputs.artifacts_found == 'true'
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Download artifacts
+        uses: actions/download-artifact@v3
+        with:
+          name: release-artifacts
+          path: artifacts
 
       - name: Upload Release Assets
-        if: steps.wait-for-assets.outputs.exit_code == '0'
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
-          if [ -d "artifacts" ] && [ "$(ls -A artifacts)" ]; then
-            for file in artifacts/*/*.zip; do
-              gh release upload ${{ steps.release.outputs.tag_name }} "$file" --clobber
-            done
-              else
-            echo "No artifacts found to upload"
-          fi
+          for file in artifacts/*/*.zip; do
+            gh release upload ${{ needs.release-please.outputs.tag_name }} $file --clobber
+          done