fix: compute time values per-request in check-schedule endpoint

Move current_time_local and current_day from module-level constants
into should_post_to_slack() so they reflect request time instead of
server startup time. Remove unused current_time_utc. Add test that
mocks arrow.now to verify the endpoint uses request-time values.

Closes TASK-020

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: pythoninthegrass

app/main.py

@@ -45,10 +45,6 @@
 bypass_schedule = config("OVERRIDE", default=False, cast=bool)
 DEV = config("DEV", default=False, cast=bool)
 
-# time
-current_time_local = arrow.now(tz)
-current_time_utc = arrow.utcnow()
-current_day = current_time_local.format("dddd")  # Monday, Tuesday, etc.
 time.tzset()
 
 # pandas don't truncate output
@@ -438,6 +434,9 @@ def should_post_to_slack(auth: dict = Depends(ip_whitelist_or_auth), request: Re
     Check if it's time to post to Slack based on the schedule
     """
 
+    current_time_local = arrow.now(tz)
+    current_day = current_time_local.format("dddd")
+
     with db_session:
         check_and_revert_snooze()  # Check and revert any expired snoozes
         schedule = get_schedule(current_day)

…e-level-current_time_local-in-main.py.md …e-level-current_time_local-in-main.py.mdbacklog/tasks/task-020 - Fix-stale-module-level-current_time_local-in-main.py.md renamed to backlog/completed/task-020 - Fix-stale-module-level-current_time_local-in-main.py.md backlog/tasks/task-020 - Fix-stale-module-level-current_time_local-in-main.py.md renamed to backlog/completed/task-020 - Fix-stale-module-level-current_time_local-in-main.py.md

@@ -1,9 +1,10 @@
 ---
 id: TASK-020
 title: Fix stale module-level current_time_local in main.py
-status: To Do
+status: Done
 assignee: []
 created_date: '2026-03-21 00:58'
+updated_date: '2026-03-21 01:12'
 labels:
   - bug
 dependencies: []
@@ -21,7 +22,13 @@ priority: medium
 
 ## Acceptance Criteria
 <!-- AC:BEGIN -->
-- [ ] #1 current_time_local, current_time_utc, and current_day are computed per-request in endpoints that use them
-- [ ] #2 Existing tests continue to pass
-- [ ] #3 Add test verifying time values reflect request time, not server startup time
+- [x] #1 current_time_local, current_time_utc, and current_day are computed per-request in endpoints that use them
+- [x] #2 Existing tests continue to pass
+- [x] #3 Add test verifying time values reflect request time, not server startup time
 <!-- AC:END -->
+
+## Final Summary
+
+<!-- SECTION:FINAL_SUMMARY:BEGIN -->
+Moved `current_time_local`, `current_time_utc`, and `current_day` from module-level constants to per-request computation inside `should_post_to_slack()`. Removed `current_time_utc` entirely (unused). Added `test_check_schedule_uses_request_time` to verify the endpoint reflects request time, not server startup time.
+<!-- SECTION:FINAL_SUMMARY:END -->

tests/test_unit.py

@@ -341,6 +341,41 @@ def db_session_passthrough(f=None, *a, **kw):
         assert "should_post" in data
 
 
+@pytest.mark.unit
+def test_check_schedule_uses_request_time(test_client, auth_headers):
+    """Time values should be computed per-request, not at module load."""
+    mock_schedule_obj = MagicMock()
+    mock_schedule_obj.enabled = True
+    mock_schedule_obj.schedule_time = "14:00"
+
+    mock_db_ctx = MagicMock()
+    mock_db_ctx.__enter__ = MagicMock()
+    mock_db_ctx.__exit__ = MagicMock(return_value=False)
+
+    def db_session_passthrough(f=None, *a, **kw):
+        if f is not None and callable(f):
+            return f
+        return mock_db_ctx
+
+    request_time = arrow.Arrow(2026, 7, 15, 14, 5, tzinfo="America/Chicago")
+
+    with (
+        patch('pony.orm.db_session', side_effect=db_session_passthrough),
+        patch('main.db_session', side_effect=db_session_passthrough),
+        patch('schedule.db_session', side_effect=db_session_passthrough),
+        patch('main.check_and_revert_snooze'),
+        patch('main.get_schedule', return_value=mock_schedule_obj),
+        patch('main.get_current_schedule_time', return_value=("14:00 UTC", "14:00 CDT")),
+        patch('main.arrow') as mock_arrow,
+    ):
+        mock_arrow.now.return_value = request_time
+        mock_arrow.get = arrow.get
+        response = test_client.get("/api/check-schedule", headers=auth_headers)
+        assert response.status_code == 200
+        data = response.json()
+        assert "Wednesday" in data["current_time"], f"Expected Wednesday (request time) but got: {data['current_time']}"
+
+
 @pytest.mark.unit
 def test_post_slack(test_client, auth_headers):
     mock_message = ["Test message"]