fix(ci): add missing library count mocks, fix property test dedup, gate Playwright on tests

- Add /api/library/count mock to Playwright specs with inline library
  routes (error-states, library-playlist-features, sidebar) to match
  paginated loading added in cb6876d
- Set totalTracks=0 in library-browser empty state test to match
  HTML condition on library.totalTracks
- Fix queue property test newCount to deduplicate within playNextTracks
  input batch, not just against existing queue
- Gate Playwright on deno-lint, rust, vitest-tests so it doesn't run
  when upstream jobs fail
- Gate builds on all test jobs (rust, vitest, playwright) with
  !failure() && !cancelled() so skipped playwright doesn't block
- Remove continue-on-error from vitest step
- Add setup-test mode to composite action for cargo-nextest via binstall

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: pythoninthegrass

.github/actions/setup-tauri-build/action.yml

@@ -6,7 +6,7 @@ inputs:
     description: 'Node.js version'
     default: '20'
   mode:
-    description: 'Setup mode: "full" installs everything for Tauri builds; "check" installs only Rust + Task for cargo check/clippy'
+    description: 'Setup mode: "full" installs everything for Tauri builds; "check" installs only Rust + Task for cargo check/clippy; "test" adds cargo-nextest via binstall'
     default: 'full'
 
 runs:
@@ -107,6 +107,11 @@ runs:
       shell: bash
       run: task ci:setup-check
 
+    - name: Setup CI environment (macOS/Linux, test)
+      if: inputs.mode == 'test' && runner.os != 'Windows'
+      shell: bash
+      run: task ci:setup-test
+
     - name: Install system dependencies (Windows)
       if: runner.os == 'Windows'
       shell: pwsh
@@ -146,7 +151,7 @@ runs:
         }
 
     - name: Install cargo-binstall (Windows)
-      if: inputs.mode == 'full' && runner.os == 'Windows'
+      if: (inputs.mode == 'full' || inputs.mode == 'test') && runner.os == 'Windows'
       shell: pwsh
       run: |
         if (-not (Get-Command cargo-binstall -ErrorAction SilentlyContinue)) {
@@ -169,6 +174,11 @@ runs:
       shell: pwsh
       run: task ci:setup-check PINNED_RUST=${{ steps.rust-version-windows.outputs.toolchain }}
 
+    - name: Setup CI environment (Windows, test)
+      if: inputs.mode == 'test' && runner.os == 'Windows'
+      shell: pwsh
+      run: task ci:setup-test PINNED_RUST=${{ steps.rust-version-windows.outputs.toolchain }}
+
     - name: Windows Defender exclusions
       if: runner.os == 'Windows'
       shell: pwsh

.github/workflows/test.yml

@@ -49,7 +49,7 @@ jobs:
       - name: Setup Tauri build environment
         uses: ./.github/actions/setup-tauri-build
         with:
-          mode: check
+          mode: test
 
       - name: Cargo fmt check
         run: cargo fmt --all -- --check
@@ -122,7 +122,8 @@ jobs:
     name: Build (${{ matrix.platform }})
     # Gate on lint/format/test jobs so builds don't burn CI minutes
     # when basic checks fail.
-    needs: [deno-lint, rust]
+    needs: [deno-lint, rust, vitest-tests, playwright-tests]
+    if: ${{ !failure() && !cancelled() }}
     strategy:
       fail-fast: false
       matrix:
@@ -220,7 +221,6 @@ jobs:
       - name: Run Vitest with coverage
         working-directory: ./app/frontend
         run: npm run test:coverage
-        continue-on-error: true
 
       - name: Upload coverage report
         if: always()
@@ -249,8 +249,8 @@ jobs:
 
   playwright-tests:
     name: Playwright E2E Tests
-    needs: [changes]
-    if: needs.changes.outputs.frontend == 'true' || github.event_name == 'push'
+    needs: [changes, deno-lint, rust, vitest-tests]
+    if: ${{ !failure() && !cancelled() && (needs.changes.outputs.frontend == 'true' || github.event_name == 'push') }}
     runs-on: [macOS, ARM64]
     timeout-minutes: 20
 

app/frontend/__tests__/queue.props.test.js

@@ -626,9 +626,13 @@ describe('Queue Store - Property-Based Tests', () => {
         });
 
         const originalIds = tracks.map((t) => t.id);
-        // playNextTracks uses move semantics — duplicates are moved, not rejected
+        // playNextTracks uses move semantics — duplicates within the input are
+        // also deduplicated, so count only unique new IDs
         const existingIds = new Set(originalIds);
-        const newCount = playNextTracks.filter((t) => !existingIds.has(t.id)).length;
+        const uniqueNewIds = new Set(
+          playNextTracks.filter((t) => !existingIds.has(t.id)).map((t) => t.id),
+        );
+        const newCount = uniqueNewIds.size;
 
         const promise = store.playNextTracks(playNextTracks);
         resolvePromise();

app/frontend/tests/error-states.spec.js

@@ -1,17 +1,7 @@
-import { test, expect } from '@playwright/test';
-import {
-  waitForAlpine,
-  getAlpineStore,
-  setAlpineStoreProperty,
-} from './fixtures/helpers.js';
-import {
-  createLibraryState,
-  setupLibraryMocks,
-} from './fixtures/mock-library.js';
-import {
-  createPlaylistState,
-  setupPlaylistMocks,
-} from './fixtures/mock-playlists.js';
+import { expect, test } from '@playwright/test';
+import { getAlpineStore, setAlpineStoreProperty, waitForAlpine } from './fixtures/helpers.js';
+import { createLibraryState, setupLibraryMocks } from './fixtures/mock-library.js';
+import { createPlaylistState, setupPlaylistMocks } from './fixtures/mock-playlists.js';
 
 /**
  * Error States and Toast Notification Tests
@@ -59,6 +49,18 @@ test.describe('Network Failure Handling', () => {
     let requestCount = 0;
     const libraryState = createLibraryState({ trackCount: 10 });
 
+    // Mock /api/library/count (pagination support)
+    await page.route(/\/api\/library\/count(\?.*)?$/, async (route) => {
+      await route.fulfill({
+        status: 200,
+        contentType: 'application/json',
+        body: JSON.stringify({
+          total: libraryState.tracks.length,
+          total_duration: libraryState.tracks.reduce((sum, t) => sum + (t.duration || 0), 0),
+        }),
+      });
+    });
+
     // First request fails, subsequent succeed
     await page.route(/\/api\/library(\?.*)?$/, async (route) => {
       requestCount++;
@@ -91,7 +93,9 @@ test.describe('Network Failure Handling', () => {
     await waitForAlpine(page);
 
     // Wait for tracks to load
-    await page.waitForSelector('[data-track-id]', { state: 'visible', timeout: 5000 }).catch(() => {});
+    await page.waitForSelector('[data-track-id]', { state: 'visible', timeout: 5000 }).catch(
+      () => {},
+    );
 
     const libraryStore = await getAlpineStore(page, 'library');
     expect(libraryStore.tracks.length).toBeGreaterThan(0);
@@ -850,6 +854,18 @@ test.describe('Concurrent Request Handling', () => {
     let requestCount = 0;
     const libraryState = createLibraryState({ trackCount: 10 });
 
+    // Mock /api/library/count (pagination support)
+    await page.route(/\/api\/library\/count(\?.*)?$/, async (route) => {
+      await route.fulfill({
+        status: 200,
+        contentType: 'application/json',
+        body: JSON.stringify({
+          total: libraryState.tracks.length,
+          total_duration: libraryState.tracks.reduce((sum, t) => sum + (t.duration || 0), 0),
+        }),
+      });
+    });
+
     await page.route(/\/api\/library(\?.*)?$/, async (route) => {
       requestCount++;
       // Small delay to simulate server processing

app/frontend/tests/library-browser.spec.js

@@ -60,6 +60,7 @@ test.describe('Library Browser', () => {
     await page.evaluate(() => {
       window.Alpine.store('library').tracks = [];
       window.Alpine.store('library').filteredTracks = [];
+      window.Alpine.store('library').totalTracks = 0;
       window.Alpine.store('library').loading = false;
     });
 

app/frontend/tests/library-playlist-features.spec.js

@@ -18,6 +18,14 @@ test.describe('Playlist Feature Parity - Library Browser (task-150)', () => {
     clearApiCalls(playlistState);
     // Setup playlist API mocks before navigation
     await setupPlaylistMocks(page, playlistState);
+    // Mock library count endpoint (pagination support)
+    await page.route(/\/api\/library\/count(\?.*)?$/, async (route) => {
+      await route.fulfill({
+        status: 200,
+        contentType: 'application/json',
+        body: JSON.stringify({ total: 2, total_duration: 380 }),
+      });
+    });
     // Also mock library tracks endpoint
     await page.route(/\/api\/library(\?.*)?$/, async (route) => {
       await route.fulfill({
@@ -293,6 +301,15 @@ test.describe('Playlist load regression guard (task-179)', () => {
 
     await setupPlaylistMocks(page, playlistState);
 
+    // Mock library count endpoint (pagination support)
+    await page.route(/\/api\/library\/count(\?.*)?$/, async (route) => {
+      await route.fulfill({
+        status: 200,
+        contentType: 'application/json',
+        body: JSON.stringify({ total: 1, total_duration: 180 }),
+      });
+    });
+
     await page.route(/\/api\/library(\?.*)?$/, async (route, request) => {
       if (request.method() !== 'GET') {
         await route.continue();

app/frontend/tests/sidebar.spec.js

@@ -1,13 +1,10 @@
-import { test, expect } from '@playwright/test';
+import { expect, test } from '@playwright/test';
+import { getAlpineStore, waitForAlpine } from './fixtures/helpers.js';
 import {
-  waitForAlpine,
-  getAlpineStore,
-} from './fixtures/helpers.js';
-import {
-  createPlaylistState,
-  setupPlaylistMocks,
   clearApiCalls,
+  createPlaylistState,
   findApiCalls,
+  setupPlaylistMocks,
 } from './fixtures/mock-playlists.js';
 
 test.describe('Sidebar Navigation', () => {
@@ -104,7 +101,9 @@ test.describe('Sidebar Collapse/Expand', () => {
     const initialBox = await sidebar.boundingBox();
 
     // Click collapse button
-    const collapseButton = page.locator('aside button[title*="Collapse"], aside button[title*="Expand"]').last();
+    const collapseButton = page.locator(
+      'aside button[title*="Collapse"], aside button[title*="Expand"]',
+    ).last();
     await collapseButton.click();
 
     // Wait for transition
@@ -129,7 +128,9 @@ test.describe('Sidebar Collapse/Expand', () => {
     const collapsedBox = await sidebar.boundingBox();
 
     // Click expand button
-    const expandButton = page.locator('aside button[title*="Expand"], aside button[title*="Collapse"]').last();
+    const expandButton = page.locator(
+      'aside button[title*="Expand"], aside button[title*="Collapse"]',
+    ).last();
     await expandButton.click();
 
     // Wait for transition
@@ -457,14 +458,36 @@ test.describe('Playlist Feature Parity (task-150)', () => {
   test.beforeEach(async ({ page }) => {
     clearApiCalls(playlistState);
     await setupPlaylistMocks(page, playlistState);
+    // Mock library count endpoint (pagination support)
+    await page.route(/\/api\/library\/count(\?.*)?$/, async (route) => {
+      await route.fulfill({
+        status: 200,
+        contentType: 'application/json',
+        body: JSON.stringify({ total: 2, total_duration: 380 }),
+      });
+    });
     await page.route(/\/api\/library(\?.*)?$/, async (route) => {
       await route.fulfill({
         status: 200,
         contentType: 'application/json',
         body: JSON.stringify({
           tracks: [
-            { id: 101, title: 'Track A', artist: 'Artist A', album: 'Album A', duration: 180, filepath: '/music/track-a.mp3' },
-            { id: 102, title: 'Track B', artist: 'Artist B', album: 'Album B', duration: 200, filepath: '/music/track-b.mp3' },
+            {
+              id: 101,
+              title: 'Track A',
+              artist: 'Artist A',
+              album: 'Album A',
+              duration: 180,
+              filepath: '/music/track-a.mp3',
+            },
+            {
+              id: 102,
+              title: 'Track B',
+              artist: 'Artist B',
+              album: 'Album B',
+              duration: 200,
+              filepath: '/music/track-b.mp3',
+            },
           ],
           total: 2,
         }),
@@ -545,7 +568,9 @@ test.describe('Playlist Feature Parity (task-150)', () => {
 
   test('AC#6: should show drag handle in playlist view', async ({ page }) => {
     await page.evaluate(() => {
-      const libraryBrowser = window.Alpine.$data(document.querySelector('[x-data="libraryBrowser"]'));
+      const libraryBrowser = window.Alpine.$data(
+        document.querySelector('[x-data="libraryBrowser"]'),
+      );
       libraryBrowser.currentPlaylistId = 1;
     });
 
@@ -557,7 +582,9 @@ test.describe('Playlist Feature Parity (task-150)', () => {
 
   test('AC#6: should hide drag handle outside playlist view', async ({ page }) => {
     await page.evaluate(() => {
-      const libraryBrowser = window.Alpine.$data(document.querySelector('[x-data="libraryBrowser"]'));
+      const libraryBrowser = window.Alpine.$data(
+        document.querySelector('[x-data="libraryBrowser"]'),
+      );
       libraryBrowser.currentPlaylistId = null;
     });
 
@@ -829,7 +856,7 @@ test.describe('Playlist Multi-Select and Batch Delete (task-161)', () => {
     await playlist1.click({ modifiers: ['Meta'] });
     await playlistList.focus();
 
-    page.once('dialog', async dialog => {
+    page.once('dialog', async (dialog) => {
       expect(dialog.type()).toBe('confirm');
       expect(dialog.message()).toContain('Delete playlist');
       await dialog.dismiss();
@@ -845,7 +872,7 @@ test.describe('Playlist Multi-Select and Batch Delete (task-161)', () => {
     await playlist1.click({ modifiers: ['Meta'] });
     await playlistList.focus();
 
-    page.once('dialog', async dialog => {
+    page.once('dialog', async (dialog) => {
       expect(dialog.type()).toBe('confirm');
       await dialog.dismiss();
     });
@@ -860,7 +887,7 @@ test.describe('Playlist Multi-Select and Batch Delete (task-161)', () => {
     await playlist1.click({ modifiers: ['Meta'] });
     await playlistList.focus();
 
-    page.once('dialog', async dialog => {
+    page.once('dialog', async (dialog) => {
       await dialog.accept();
     });
 
@@ -878,7 +905,7 @@ test.describe('Playlist Multi-Select and Batch Delete (task-161)', () => {
     await playlist1.click({ modifiers: ['Meta'] });
     await playlistList.focus();
 
-    page.once('dialog', async dialog => {
+    page.once('dialog', async (dialog) => {
       await dialog.dismiss();
     });
 
@@ -942,7 +969,7 @@ test.describe('Playlist Multi-Select and Batch Delete (task-161)', () => {
     await playlist2.click({ modifiers: ['Meta'] });
     await playlistList.focus();
 
-    page.once('dialog', async dialog => {
+    page.once('dialog', async (dialog) => {
       expect(dialog.message()).toContain('Delete selected playlists');
       expect(dialog.message()).toContain('Test Playlist 1');
       expect(dialog.message()).toContain('Test Playlist 2');

taskfiles/ci.yml

@@ -34,6 +34,13 @@ tasks:
     desc: "Setup CI check environment (Rust only, no cargo-binstall/tauri-cli)"
     deps: [setup-system-deps, setup-rust, setup-rust-windows]
 
+  setup-test:
+    desc: "Setup CI test environment (Rust + cargo-nextest)"
+    deps: [setup-system-deps, setup-rust, setup-rust-windows]
+    cmds:
+      - task: _install-cargo-binstall
+      - task: _install-cargo-nextest
+
   setup-rust:
     desc: "Install rustup and nightly toolchain (macOS/Linux)"
     platforms: [darwin, linux]
@@ -79,6 +86,13 @@ tasks:
     status:
       - test -x "{{.CARGO_BIN}}/cargo-binstall"
 
+  _install-cargo-nextest:
+    internal: true
+    cmds:
+      - cargo binstall cargo-nextest --locked --no-confirm
+    status:
+      - command -v cargo-nextest
+
   _install-tauri-cli:
     internal: true
     cmds: