refactor: extract composite actions and consolidate test mocks (task-336.3)

- Add .github/actions/resolve-release-tag: bash+pwsh composite action; replace 4 inline blocks in release.yml
- Add .github/actions/setup-frontend: setup-node@v6+npm-ci composite action; replace 3 inline blocks in test.yml/test-local.yml
- Add taskfiles/tauri.yml _deps-base-build internal task; replace 7 inlined dep triples
- Add app/frontend/__tests__/mocks/tauri.js and mocks/api.js shared mock factories
- Update player.props.test.js, playback-regression.test.js, setup-player-mocks.js to import from mocks/

Author: pythoninthegrass

.github/actions/resolve-release-tag/action.yml

@@ -0,0 +1,53 @@
+name: 'Resolve Release Tag'
+description: 'Resolve the release tag and export RELEASE_TAG to the environment. Supports bash and pwsh.'
+
+inputs:
+  event-name:
+    description: 'github.event_name from the calling workflow'
+    required: true
+  release-tag:
+    description: 'The release-tag workflow input (defaults to "latest")'
+    required: false
+    default: 'latest'
+  release-tag-name:
+    description: 'github.event.release.tag_name for release events'
+    required: false
+    default: ''
+  github-token:
+    description: 'GitHub token for gh CLI'
+    required: true
+
+runs:
+  using: 'composite'
+  steps:
+    - name: Resolve release tag (bash)
+      if: runner.os != 'Windows'
+      shell: bash
+      env:
+        GH_TOKEN: ${{ inputs.github-token }}
+      run: |
+        if [ "${{ inputs.event-name }}" = "release" ]; then
+          tag="${{ inputs.release-tag-name }}"
+        elif [ "${{ inputs.release-tag }}" != "latest" ] && [ -n "${{ inputs.release-tag }}" ]; then
+          tag="${{ inputs.release-tag }}"
+        else
+          tag="$(gh release view --json tagName -q .tagName)"
+        fi
+        echo "RELEASE_TAG=$tag" >> "$GITHUB_ENV"
+        echo "Resolved release tag: $tag"
+
+    - name: Resolve release tag (pwsh)
+      if: runner.os == 'Windows'
+      shell: pwsh
+      env:
+        GH_TOKEN: ${{ inputs.github-token }}
+      run: |
+        if ("${{ inputs.event-name }}" -eq "release") {
+          $tag = "${{ inputs.release-tag-name }}"
+        } elseif ("${{ inputs.release-tag }}" -ne "latest" -and "${{ inputs.release-tag }}" -ne "") {
+          $tag = "${{ inputs.release-tag }}"
+        } else {
+          $tag = (gh release view --json tagName -q .tagName)
+        }
+        echo "RELEASE_TAG=$tag" >> $env:GITHUB_ENV
+        Write-Host "Resolved release tag: $tag"

.github/actions/setup-frontend/action.yml

@@ -0,0 +1,31 @@
+name: 'Setup Frontend'
+description: 'Install Node.js and run npm ci for the frontend'
+
+inputs:
+  node-version:
+    description: 'Node.js version'
+    required: false
+    default: '20'
+  cache:
+    description: 'Package manager for caching (npm/yarn/pnpm, or empty to disable)'
+    required: false
+    default: ''
+  cache-dependency-path:
+    description: 'Path to lockfile for cache key (only used when cache is set)'
+    required: false
+    default: 'app/frontend/package-lock.json'
+
+runs:
+  using: 'composite'
+  steps:
+    - name: Setup Node.js
+      uses: actions/setup-node@v6
+      with:
+        node-version: ${{ inputs.node-version }}
+        cache: ${{ inputs.cache }}
+        cache-dependency-path: ${{ inputs.cache-dependency-path }}
+
+    - name: Install frontend dependencies
+      shell: bash
+      working-directory: ./app/frontend
+      run: npm ci

.github/workflows/release.yml

@@ -52,18 +52,12 @@ jobs:
       - uses: actions/checkout@v6
 
       - name: Resolve release tag
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          if [ "${{ github.event_name }}" = "release" ]; then
-            tag="${{ github.event.release.tag_name }}"
-          elif [ "${{ inputs.release-tag }}" != "latest" ] && [ -n "${{ inputs.release-tag }}" ]; then
-            tag="${{ inputs.release-tag }}"
-          else
-            tag="$(gh release view --json tagName -q .tagName)"
-          fi
-          echo "RELEASE_TAG=$tag" >> "$GITHUB_ENV"
-          echo "Resolved release tag: $tag"
+        uses: ./.github/actions/resolve-release-tag
+        with:
+          event-name: ${{ github.event_name }}
+          release-tag: ${{ inputs.release-tag }}
+          release-tag-name: ${{ github.event.release.tag_name }}
+          github-token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Setup Tauri build environment
         uses: ./.github/actions/setup-tauri-build
@@ -147,18 +141,12 @@ jobs:
       - uses: actions/checkout@v6
 
       - name: Resolve release tag
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          if [ "${{ github.event_name }}" = "release" ]; then
-            tag="${{ github.event.release.tag_name }}"
-          elif [ "${{ inputs.release-tag }}" != "latest" ] && [ -n "${{ inputs.release-tag }}" ]; then
-            tag="${{ inputs.release-tag }}"
-          else
-            tag="$(gh release view --json tagName -q .tagName)"
-          fi
-          echo "RELEASE_TAG=$tag" >> "$GITHUB_ENV"
-          echo "Resolved release tag: $tag"
+        uses: ./.github/actions/resolve-release-tag
+        with:
+          event-name: ${{ github.event_name }}
+          release-tag: ${{ inputs.release-tag }}
+          release-tag-name: ${{ github.event.release.tag_name }}
+          github-token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Setup Docker builder
         uses: useblacksmith/setup-docker-builder@v1
@@ -202,19 +190,12 @@ jobs:
       - uses: actions/checkout@v6
 
       - name: Resolve release tag
-        shell: pwsh
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          if ("${{ github.event_name }}" -eq "release") {
-            $tag = "${{ github.event.release.tag_name }}"
-          } elseif ("${{ inputs.release-tag }}" -ne "latest" -and "${{ inputs.release-tag }}" -ne "") {
-            $tag = "${{ inputs.release-tag }}"
-          } else {
-            $tag = (gh release view --json tagName -q .tagName)
-          }
-          echo "RELEASE_TAG=$tag" >> $env:GITHUB_ENV
-          Write-Host "Resolved release tag: $tag"
+        uses: ./.github/actions/resolve-release-tag
+        with:
+          event-name: ${{ github.event_name }}
+          release-tag: ${{ inputs.release-tag }}
+          release-tag-name: ${{ github.event.release.tag_name }}
+          github-token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Setup Tauri build environment
         uses: ./.github/actions/setup-tauri-build
@@ -322,18 +303,12 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Resolve release tag
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          if [ "${{ github.event_name }}" = "release" ]; then
-            tag="${{ github.event.release.tag_name }}"
-          elif [ "${{ inputs.release-tag }}" != "latest" ] && [ -n "${{ inputs.release-tag }}" ]; then
-            tag="${{ inputs.release-tag }}"
-          else
-            tag="$(gh release view --json tagName -q .tagName)"
-          fi
-          echo "RELEASE_TAG=$tag" >> "$GITHUB_ENV"
-          echo "Resolved release tag: $tag"
+        uses: ./.github/actions/resolve-release-tag
+        with:
+          event-name: ${{ github.event_name }}
+          release-tag: ${{ inputs.release-tag }}
+          release-tag-name: ${{ github.event.release.tag_name }}
+          github-token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Update download table
         env:

.github/workflows/test-local.yml

@@ -40,17 +40,12 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v6
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v5
+      - name: Setup frontend
+        uses: ./.github/actions/setup-frontend
         with:
-          node-version: '20'
           cache: 'npm'
           cache-dependency-path: app/frontend/package-lock.json
 
-      - name: Install frontend dependencies
-        working-directory: ./app/frontend
-        run: npm ci
-
       - name: Run Vitest with coverage
         working-directory: ./app/frontend
         run: npm run test:coverage

.github/workflows/test.yml

@@ -160,17 +160,12 @@ jobs:
     steps:
       - uses: actions/checkout@v6
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v6
+      - name: Setup frontend
+        uses: ./.github/actions/setup-frontend
         with:
-          node-version: '20'
           cache: 'npm'
           cache-dependency-path: app/frontend/package-lock.json
 
-      - name: Install frontend dependencies
-        working-directory: ./app/frontend
-        run: npm ci
-
       - name: Run Vitest with coverage
         working-directory: ./app/frontend
         run: npm run test:coverage
@@ -210,14 +205,8 @@ jobs:
     steps:
       - uses: actions/checkout@v6
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v6
-        with:
-          node-version: '20'
-
-      - name: Install frontend dependencies
-        working-directory: ./app/frontend
-        run: npm ci
+      - name: Setup frontend
+        uses: ./.github/actions/setup-frontend
 
       - name: Install Playwright browsers
         working-directory: ./app/frontend

app/frontend/__tests__/mocks/api.js

@@ -0,0 +1,26 @@
+import { vi } from 'vitest';
+
+/**
+ * @param {Record<string,unknown>} [overrides] - additional api namespaces to merge in
+ */
+export function createApiMock(overrides = {}) {
+  return {
+    api: {
+      favorites: {
+        check: vi.fn().mockResolvedValue({ is_favorite: false }),
+        add: vi.fn().mockResolvedValue({}),
+        remove: vi.fn().mockResolvedValue({}),
+      },
+      library: {
+        getArtwork: vi.fn().mockResolvedValue(null),
+        updatePlayCount: vi.fn().mockResolvedValue({}),
+      },
+      lastfm: {
+        getSettings: vi.fn().mockResolvedValue({ enabled: false, authenticated: false, scrobble_threshold: 90 }),
+        updateNowPlaying: vi.fn().mockResolvedValue({ status: 'disabled' }),
+        scrobble: vi.fn().mockResolvedValue({ status: 'disabled' }),
+      },
+      ...overrides,
+    },
+  };
+}

app/frontend/__tests__/mocks/tauri.js

@@ -0,0 +1,36 @@
+import { vi } from 'vitest';
+
+const VOID_CMDS = new Set([
+  'audio_seek',
+  'audio_set_volume',
+  'audio_stop',
+  'audio_play',
+  'audio_pause',
+  'queue_clear',
+]);
+
+const DEFAULT_RETURNS = {
+  audio_get_status: { volume: 1.0 },
+  audio_load: { duration_ms: 180000 },
+};
+
+/**
+ * @param {{ invokeReturns?: Record<string,unknown>, voidCmds?: string[] }} [opts]
+ */
+export function createTauriMock({ invokeReturns = {}, voidCmds = [] } = {}) {
+  const returns = { ...DEFAULT_RETURNS, ...invokeReturns };
+  const voidSet = new Set([...VOID_CMDS, ...voidCmds]);
+  return {
+    __TAURI__: {
+      core: {
+        invoke: vi.fn((cmd) => {
+          if (voidSet.has(cmd)) return Promise.resolve();
+          return Promise.resolve(returns[cmd] ?? {});
+        }),
+      },
+      event: {
+        listen: vi.fn(() => Promise.resolve(() => {})),
+      },
+    },
+  };
+}

app/frontend/__tests__/playback-regression.test.js

@@ -11,50 +11,28 @@
  */
 
 import { describe, it, expect, beforeEach, vi } from 'vitest';
+import { createTauriMock } from './mocks/tauri.js';
 
-// Mock Tauri IPC — must be set before module imports
-global.window = {
-  __TAURI__: {
-    core: {
-      invoke: vi.fn((cmd) => {
-        if (cmd === 'audio_get_status') return Promise.resolve({ volume: 1.0, state: 'Stopped' });
-        if (cmd === 'queue_get') return Promise.resolve({ items: [], current_index: -1 });
-        if (cmd === 'queue_clear') return Promise.resolve();
-        if (cmd === 'queue_get_playback_state') return Promise.resolve({ shuffle: false, loop: 'none', current_index: -1 });
-        return Promise.resolve({});
-      }),
-    },
-    event: {
-      listen: vi.fn(() => Promise.resolve(() => {})),
-    },
+global.window = createTauriMock({
+  invokeReturns: {
+    audio_get_status: { volume: 1.0, state: 'Stopped' },
+    queue_get: { items: [], current_index: -1 },
+    queue_get_playback_state: { shuffle: false, loop: 'none', current_index: -1 },
   },
-};
+});
 
-vi.mock('../js/api.js', () => ({
-  api: {
-    favorites: {
-      check: vi.fn().mockResolvedValue({ is_favorite: false }),
-      add: vi.fn().mockResolvedValue({}),
-      remove: vi.fn().mockResolvedValue({}),
-    },
-    library: {
-      getArtwork: vi.fn().mockResolvedValue(null),
-      updatePlayCount: vi.fn().mockResolvedValue({}),
-    },
-    lastfm: {
-      getSettings: vi.fn().mockResolvedValue({ enabled: false, authenticated: false, scrobble_threshold: 90 }),
-      updateNowPlaying: vi.fn().mockResolvedValue({ status: 'disabled' }),
-      scrobble: vi.fn().mockResolvedValue({ status: 'disabled' }),
-    },
+vi.mock('../js/api.js', async () => {
+  const { createApiMock } = await import('./mocks/api.js');
+  return createApiMock({
     queue: {
       get: vi.fn().mockResolvedValue({ items: [], current_index: -1 }),
       clear: vi.fn().mockResolvedValue({}),
       add: vi.fn().mockResolvedValue({}),
       remove: vi.fn().mockResolvedValue({}),
       reorder: vi.fn().mockResolvedValue({}),
     },
-  },
-}));
+  });
+});
 
 import { createPlayerStore } from '../js/stores/player.js';
 import { createQueueStore } from '../js/stores/queue.js';