fix(rust): resolve clippy linting warnings

- Replace min().max() with clamp() for cleaner bounds checking
- Implement FromStr trait for LibrarySortColumn instead of custom from_str
- Use matches! macro instead of match expression for boolean returns
- Allow clippy::too_many_arguments for Tauri command (unavoidable)
- Update tests to use FromStr trait implementation
- Remove unused import

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: pythoninthegrass

src-tauri/src/commands/favorites.rs

@@ -51,7 +51,7 @@ pub fn favorites_get(
     limit: Option<i64>,
     offset: Option<i64>,
 ) -> Result<FavoritesResponse, String> {
-    let limit = limit.unwrap_or(100).min(1000).max(1);
+    let limit = limit.unwrap_or(100).clamp(1, 1000);
     let offset = offset.unwrap_or(0).max(0);
 
     let conn = db.conn().map_err(|e| e.to_string())?;
@@ -146,8 +146,8 @@ pub fn favorites_get_recently_played(
     days: Option<i64>,
     limit: Option<i64>,
 ) -> Result<RecentTracksResponse, String> {
-    let days = days.unwrap_or(14).min(365).max(1);
-    let limit = limit.unwrap_or(100).min(1000).max(1);
+    let days = days.unwrap_or(14).clamp(1, 365);
+    let limit = limit.unwrap_or(100).clamp(1, 1000);
 
     let conn = db.conn().map_err(|e| e.to_string())?;
     let tracks = favorites::get_recently_played(&conn, days, limit).map_err(|e| e.to_string())?;
@@ -162,8 +162,8 @@ pub fn favorites_get_recently_added(
     days: Option<i64>,
     limit: Option<i64>,
 ) -> Result<RecentTracksResponse, String> {
-    let days = days.unwrap_or(14).min(365).max(1);
-    let limit = limit.unwrap_or(100).min(1000).max(1);
+    let days = days.unwrap_or(14).clamp(1, 365);
+    let limit = limit.unwrap_or(100).clamp(1, 1000);
 
     let conn = db.conn().map_err(|e| e.to_string())?;
     let tracks = favorites::get_recently_added(&conn, days, limit).map_err(|e| e.to_string())?;

src-tauri/src/commands/lastfm.rs

@@ -14,10 +14,7 @@ use tauri::{AppHandle, Emitter, State};
 
 /// Helper to check if a setting is truthy
 fn is_setting_truthy(value: Option<String>) -> bool {
-    match value.as_deref() {
-        Some("1") | Some("true") | Some("yes") | Some("on") => true,
-        _ => false,
-    }
+    matches!(value.as_deref(), Some("1") | Some("true") | Some("yes") | Some("on"))
 }
 
 /// Helper to parse setting as u8

src-tauri/src/db/models.rs

@@ -178,16 +178,13 @@ pub struct PaginatedResult<T> {
 
 /// Sort order for queries
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[derive(Default)]
 pub enum SortOrder {
     Asc,
+    #[default]
     Desc,
 }
 
-impl Default for SortOrder {
-    fn default() -> Self {
-        SortOrder::Desc
-    }
-}
 
 impl SortOrder {
     pub fn as_sql(&self) -> &'static str {
@@ -200,21 +197,18 @@ impl SortOrder {
 
 /// Valid sort columns for library queries
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[derive(Default)]
 pub enum LibrarySortColumn {
     Title,
     Artist,
     Album,
+    #[default]
     AddedDate,
     PlayCount,
     Duration,
     LastPlayed,
 }
 
-impl Default for LibrarySortColumn {
-    fn default() -> Self {
-        LibrarySortColumn::AddedDate
-    }
-}
 
 impl LibrarySortColumn {
     pub fn as_sql(&self) -> &'static str {
@@ -228,9 +222,13 @@ impl LibrarySortColumn {
             LibrarySortColumn::LastPlayed => "last_played",
         }
     }
+}
+
+impl std::str::FromStr for LibrarySortColumn {
+    type Err = ();
 
-    pub fn from_str(s: &str) -> Self {
-        match s.to_lowercase().as_str() {
+    fn from_str(s: &str) -> Result<Self, Self::Err> {
+        Ok(match s.to_lowercase().as_str() {
             "title" => LibrarySortColumn::Title,
             "artist" => LibrarySortColumn::Artist,
             "album" => LibrarySortColumn::Album,
@@ -239,7 +237,7 @@ impl LibrarySortColumn {
             "duration" => LibrarySortColumn::Duration,
             "last_played" => LibrarySortColumn::LastPlayed,
             _ => LibrarySortColumn::AddedDate,
-        }
+        })
     }
 }
 
@@ -268,16 +266,18 @@ mod tests {
 
     #[test]
     fn test_sort_column_from_str() {
+        use std::str::FromStr;
+
         assert_eq!(
-            LibrarySortColumn::from_str("title"),
+            LibrarySortColumn::from_str("title").unwrap(),
             LibrarySortColumn::Title
         );
         assert_eq!(
-            LibrarySortColumn::from_str("ARTIST"),
+            LibrarySortColumn::from_str("ARTIST").unwrap(),
             LibrarySortColumn::Artist
         );
         assert_eq!(
-            LibrarySortColumn::from_str("invalid"),
+            LibrarySortColumn::from_str("invalid").unwrap(),
             LibrarySortColumn::AddedDate
         );
     }

src-tauri/src/library/commands.rs

@@ -7,7 +7,7 @@ use std::path::Path;
 use tauri::{AppHandle, State};
 
 use crate::db::{
-    library, Database, LibrarySortColumn, LibraryStats, SortOrder, Track, TrackMetadata,
+    library, Database, LibraryStats, SortOrder, Track, TrackMetadata,
 };
 use crate::events::{EventEmitter, LibraryUpdatedEvent};
 use crate::scanner::artwork::Artwork;
@@ -32,6 +32,7 @@ pub struct MissingTracksResponse {
 }
 
 /// Get all tracks with filtering, sorting, and pagination
+#[allow(clippy::too_many_arguments)]
 #[tauri::command]
 pub fn library_get_all(
     db: State<'_, Database>,
@@ -54,7 +55,7 @@ pub fn library_get_all(
         album,
         sort_by: sort_by
             .as_ref()
-            .map(|s| LibrarySortColumn::from_str(s))
+            .and_then(|s| s.parse().ok())
             .unwrap_or_default(),
         sort_order: sort_order
             .as_ref()
@@ -260,8 +261,8 @@ pub fn library_locate_track(
     // 2. The watcher detected the file at new location and added it as a "new" track
     // 3. User uses "Locate" to point the missing track to the same file
     let mut deleted_duplicate_id: Option<i64> = None;
-    if let Ok(Some(existing_track)) = library::get_track_by_filepath(&conn, &new_path) {
-        if existing_track.id != track_id {
+    if let Ok(Some(existing_track)) = library::get_track_by_filepath(&conn, &new_path)
+        && existing_track.id != track_id {
             // There's a duplicate track at this path - remove it
             // The original track (being located) takes precedence to preserve play history
             println!(
@@ -271,7 +272,6 @@ pub fn library_locate_track(
             library::delete_track(&conn, existing_track.id).map_err(|e| e.to_string())?;
             deleted_duplicate_id = Some(existing_track.id);
         }
-    }
 
     // Update the filepath (also clears missing flag and updates last_seen_at)
     library::update_track_filepath(&conn, track_id, &new_path).map_err(|e| e.to_string())?;