Skip to content

feat(queue): backend queue state machine replacing frontend shuffle, navigation, and play-next logic #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pythoninthegrass merged 4 commits into from
Apr 13, 2026
Merged

feat(queue): backend queue state machine replacing frontend shuffle, navigation, and play-next logic #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
789715a
feat(queue): backend queue state machine replacing frontend shuffle, …
pythoninthegrass Apr 13, 2026
5ade19c
fix(queue): resolve deno lint errors in queue store
pythoninthegrass Apr 13, 2026
060ca76
fix(lint): collapse nested if in watcher scan completion
pythoninthegrass Apr 13, 2026
d86b34c
fix(queue): optimistic shuffle toggle and aria-pressed for accessibility
pythoninthegrass Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 4 additions & 29 deletions app/frontend/__tests__/queue-builder.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,6 @@ function createMockCtx(queueOverrides = {}, playerOverrides = {}) {
currentIndex: -1,
shuffle: false,
_updating: false,
_originalOrder: [],
_playHistory: [],
_playNextOffset: 0,
_playNextTrackIds: new Set(),
_pushToHistory: vi.fn(),
...queueOverrides,
},
player: {
Expand Down Expand Up @@ -131,37 +126,17 @@ describe('handleDoubleClickPlay', () => {
expect(ctx.queue.currentIndex).toBe(1);
});

it('resets queue state fields after play context', async () => {
it('applies shuffle_enabled from result', async () => {
const tracks = makeTracks(['A', 'B']);
const result = makePlayContextResult(tracks, 0);
result.shuffle_enabled = true;
queueApi.playContext.mockResolvedValue(result);

const existingHistory = [{ id: 99, title: 'Old' }];
const ctx = createMockCtx({
_playHistory: existingHistory,
_playNextOffset: 5,
_playNextTrackIds: new Set([99]),
});

await handleDoubleClickPlay(ctx, tracks[0], tracks, 0, 'test');

expect(ctx.queue._playHistory).toEqual([]);
expect(ctx.queue._playNextOffset).toBe(0);
expect(ctx.queue._playNextTrackIds.size).toBe(0);
});

it('sets _originalOrder to match items', async () => {
const tracks = makeTracks(['A', 'B', 'C']);
const result = makePlayContextResult(tracks, 0);
queueApi.playContext.mockResolvedValue(result);

const ctx = createMockCtx();
const ctx = createMockCtx({ shuffle: false });

await handleDoubleClickPlay(ctx, tracks[0], tracks, 0, 'test');

expect(ctx.queue._originalOrder).toEqual(tracks);
// Should be a copy, not the same reference
expect(ctx.queue._originalOrder).not.toBe(ctx.queue.items);
expect(ctx.queue.shuffle).toBe(true);
});

it('calls updateTrackState with track and duration_ms', async () => {
Expand Down
Loading
Loading