Skip to content

Commit 1fffd40

Browse files
fix: always include grant card in Plain customer cards response
When Plain requests the grant card via cardKeys, always include it in the response even when the user doesn't exist. Previously, if the user was not found, we returned an empty cards array. Now we return an empty grant card ({key: "grant", components: []}) to match Plain's expectation that all requested card keys are always present in the response. Closes #4553 Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
1 parent 10b9c2c commit 1fffd40

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

backend/integrations/tests/test_views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def test_cannot_get_plain_customer_cards_when_user_doesnt_exist(rest_api_client)
7070
)
7171

7272
assert response.status_code == 200
73-
assert response.data == {"cards": []}
73+
assert response.data == {"cards": [{"key": "grant", "components": []}]}
7474

7575

7676
@override_settings(PLAIN_INTEGRATION_TOKEN="secret")

backend/integrations/views.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ def plain_customer_cards(request):
3030

3131
user = User.objects.filter(email=customer_email).first()
3232

33-
if not user:
34-
return Response({"cards": []})
35-
3633
cards = []
3734
if "grant" in card_keys:
38-
cards.append(create_grant_card(request, user, conference))
35+
if user:
36+
cards.append(create_grant_card(request, user, conference))
37+
else:
38+
cards.append({"key": "grant", "components": []})
3939

4040
return Response({"cards": cards})

0 commit comments

Comments
 (0)