Skip to content

Commit 284a023

Browse files
fix: add deterministic ordering by id to review recap views
Proposals with the same score were appearing in non-deterministic order in the review system recap views. Added secondary sort by `id` to both the grants recap view and proposals recap view to ensure consistent ordering. Fixes #4535 Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
1 parent f74c682 commit 284a023

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

backend/reviews/admin.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,7 @@ def _review_grants_recap_view(self, request, review_session):
468468
).values_list("category_id", flat=True)
469469
),
470470
)
471-
.order_by(F("score").desc(nulls_last=True))
471+
.order_by(F("score").desc(nulls_last=True), "id")
472472
.prefetch_related(
473473
Prefetch(
474474
"userreview_set",
@@ -567,7 +567,7 @@ def _review_proposals_recap_view(self, request, review_session):
567567
.values("score")
568568
)
569569
)
570-
.order_by(F("score").desc(nulls_last=True))
570+
.order_by(F("score").desc(nulls_last=True), "id")
571571
.prefetch_related(
572572
Prefetch(
573573
"userreview_set",

0 commit comments

Comments
 (0)