Tests and checks

Author: patrick91

backend/reviews/admin.py

@@ -445,6 +445,9 @@ def review_recap_compute_analysis_view(self, request, review_session_id):
         if not review_session.user_can_review(request.user):
             raise PermissionDenied()
 
+        if not review_session.can_see_shortlist_screen:
+            raise PermissionDenied()
+
         conference = review_session.conference
         accepted_submissions = self._get_accepted_submissions(conference)
         force_recompute = request.GET.get("recompute") == "1"

backend/reviews/tests/test_recap.py

@@ -0,0 +1,267 @@
+import json
+
+import pytest
+from django.contrib.admin import AdminSite
+from django.core.exceptions import PermissionDenied
+
+from conferences.tests.factories import ConferenceFactory
+from reviews.admin import ReviewSessionAdmin
+from reviews.models import ReviewSession
+from reviews.tests.factories import (
+    AvailableScoreOptionFactory,
+    ReviewSessionFactory,
+)
+from submissions.models import Submission
+from submissions.tests.factories import SubmissionFactory
+from users.tests.factories import UserFactory
+
+pytestmark = pytest.mark.django_db
+
+
+def _create_recap_setup(*, session_status=ReviewSession.Status.COMPLETED):
+    """Create a review session with accepted submissions for recap tests."""
+    user = UserFactory(is_staff=True, is_superuser=True)
+    conference = ConferenceFactory()
+
+    review_session = ReviewSessionFactory(
+        conference=conference,
+        session_type=ReviewSession.SessionType.PROPOSALS,
+        status=session_status,
+    )
+    AvailableScoreOptionFactory(review_session=review_session, numeric_value=0)
+    AvailableScoreOptionFactory(review_session=review_session, numeric_value=1)
+
+    submission_1 = SubmissionFactory(
+        conference=conference, status=Submission.STATUS.accepted
+    )
+    submission_2 = SubmissionFactory(
+        conference=conference, status=Submission.STATUS.accepted
+    )
+
+    return user, conference, review_session, [submission_1, submission_2]
+
+
+# --- review_recap_view tests ---
+
+
+def test_recap_view_returns_200(rf):
+    user, conference, review_session, submissions = _create_recap_setup()
+
+    request = rf.get("/")
+    request.user = user
+
+    admin = ReviewSessionAdmin(ReviewSession, AdminSite())
+    response = admin.review_recap_view(request, review_session.id)
+
+    assert response.status_code == 200
+
+
+def test_recap_view_context_has_stats(rf):
+    user, conference, review_session, submissions = _create_recap_setup()
+
+    request = rf.get("/")
+    request.user = user
+
+    admin = ReviewSessionAdmin(ReviewSession, AdminSite())
+    response = admin.review_recap_view(request, review_session.id)
+
+    assert "total_accepted" in response.context_data
+    assert "stats_by_type" in response.context_data
+    assert "submissions_data" in response.context_data
+    assert "compute_analysis_url" in response.context_data
+    assert response.context_data["total_accepted"] == 2
+
+
+def test_recap_view_does_not_call_ml_functions(rf, mocker):
+    mock_similar = mocker.patch("reviews.admin.compute_similar_talks")
+    mock_clusters = mocker.patch("reviews.admin.compute_topic_clusters")
+
+    user, conference, review_session, submissions = _create_recap_setup()
+
+    request = rf.get("/")
+    request.user = user
+
+    admin = ReviewSessionAdmin(ReviewSession, AdminSite())
+    admin.review_recap_view(request, review_session.id)
+
+    mock_similar.assert_not_called()
+    mock_clusters.assert_not_called()
+
+
+def test_recap_view_permission_denied_for_non_reviewer(rf):
+    user = UserFactory(is_staff=True, is_superuser=False)
+    conference = ConferenceFactory()
+    review_session = ReviewSessionFactory(
+        conference=conference,
+        session_type=ReviewSession.SessionType.PROPOSALS,
+    )
+
+    request = rf.get("/")
+    request.user = user
+
+    admin = ReviewSessionAdmin(ReviewSession, AdminSite())
+
+    with pytest.raises(PermissionDenied):
+        admin.review_recap_view(request, review_session.id)
+
+
+def test_recap_view_redirects_when_shortlist_not_visible(rf, mocker):
+    mocker.patch("reviews.admin.messages")
+
+    user, conference, review_session, submissions = _create_recap_setup(
+        session_status=ReviewSession.Status.DRAFT,
+    )
+
+    # Grants sessions need COMPLETED to see shortlist; DRAFT won't work
+    review_session.session_type = ReviewSession.SessionType.GRANTS
+    review_session.save()
+
+    request = rf.get("/")
+    request.user = user
+
+    admin = ReviewSessionAdmin(ReviewSession, AdminSite())
+    response = admin.review_recap_view(request, review_session.id)
+
+    assert response.status_code == 302
+
+
+# --- review_recap_compute_analysis_view tests ---
+
+
+def test_compute_analysis_view_returns_json(rf, mocker):
+    mocker.patch(
+        "reviews.admin.compute_similar_talks",
+        return_value={},
+    )
+    mocker.patch(
+        "reviews.admin.compute_topic_clusters",
+        return_value={"topics": [], "outliers": [], "submission_topics": {}},
+    )
+
+    user, conference, review_session, submissions = _create_recap_setup()
+
+    request = rf.get("/")
+    request.user = user
+
+    admin = ReviewSessionAdmin(ReviewSession, AdminSite())
+    response = admin.review_recap_compute_analysis_view(request, review_session.id)
+
+    assert response.status_code == 200
+    assert response["Content-Type"] == "application/json"
+
+    data = json.loads(response.content)
+    assert "submissions_list" in data
+    assert "topic_clusters" in data
+
+
+def test_compute_analysis_view_passes_recompute_flag(rf, mocker):
+    mock_similar = mocker.patch(
+        "reviews.admin.compute_similar_talks",
+        return_value={},
+    )
+    mock_clusters = mocker.patch(
+        "reviews.admin.compute_topic_clusters",
+        return_value={"topics": [], "outliers": [], "submission_topics": {}},
+    )
+
+    user, conference, review_session, submissions = _create_recap_setup()
+
+    request = rf.get("/?recompute=1")
+    request.user = user
+
+    admin = ReviewSessionAdmin(ReviewSession, AdminSite())
+    admin.review_recap_compute_analysis_view(request, review_session.id)
+
+    _, kwargs = mock_similar.call_args
+    assert kwargs["force_recompute"] is True
+
+    _, kwargs = mock_clusters.call_args
+    assert kwargs["force_recompute"] is True
+
+
+def test_compute_analysis_view_no_recompute_by_default(rf, mocker):
+    mock_similar = mocker.patch(
+        "reviews.admin.compute_similar_talks",
+        return_value={},
+    )
+    mock_clusters = mocker.patch(
+        "reviews.admin.compute_topic_clusters",
+        return_value={"topics": [], "outliers": [], "submission_topics": {}},
+    )
+
+    user, conference, review_session, submissions = _create_recap_setup()
+
+    request = rf.get("/")
+    request.user = user
+
+    admin = ReviewSessionAdmin(ReviewSession, AdminSite())
+    admin.review_recap_compute_analysis_view(request, review_session.id)
+
+    _, kwargs = mock_similar.call_args
+    assert kwargs["force_recompute"] is False
+
+    _, kwargs = mock_clusters.call_args
+    assert kwargs["force_recompute"] is False
+
+
+def test_compute_analysis_view_permission_denied_for_non_reviewer(rf):
+    user = UserFactory(is_staff=True, is_superuser=False)
+    conference = ConferenceFactory()
+    review_session = ReviewSessionFactory(
+        conference=conference,
+        session_type=ReviewSession.SessionType.PROPOSALS,
+    )
+
+    request = rf.get("/")
+    request.user = user
+
+    admin = ReviewSessionAdmin(ReviewSession, AdminSite())
+
+    with pytest.raises(PermissionDenied):
+        admin.review_recap_compute_analysis_view(request, review_session.id)
+
+
+def test_compute_analysis_view_permission_denied_when_shortlist_not_visible(rf):
+    user = UserFactory(is_staff=True, is_superuser=True)
+    conference = ConferenceFactory()
+    review_session = ReviewSessionFactory(
+        conference=conference,
+        session_type=ReviewSession.SessionType.GRANTS,
+        status=ReviewSession.Status.DRAFT,
+    )
+
+    request = rf.get("/")
+    request.user = user
+
+    admin = ReviewSessionAdmin(ReviewSession, AdminSite())
+
+    with pytest.raises(PermissionDenied):
+        admin.review_recap_compute_analysis_view(request, review_session.id)
+
+
+def test_compute_analysis_view_submissions_list_sorted_by_similarity(rf, mocker):
+    user, conference, review_session, submissions = _create_recap_setup()
+    sub1, sub2 = submissions
+
+    mocker.patch(
+        "reviews.admin.compute_similar_talks",
+        return_value={
+            sub1.id: [{"id": sub2.id, "title": "Sub2", "similarity": 50.0}],
+            sub2.id: [{"id": sub1.id, "title": "Sub1", "similarity": 90.0}],
+        },
+    )
+    mocker.patch(
+        "reviews.admin.compute_topic_clusters",
+        return_value={"topics": [], "outliers": [], "submission_topics": {}},
+    )
+
+    request = rf.get("/")
+    request.user = user
+
+    admin = ReviewSessionAdmin(ReviewSession, AdminSite())
+    response = admin.review_recap_compute_analysis_view(request, review_session.id)
+    data = json.loads(response.content)
+
+    # sub2 has highest similarity (90%) so should be first
+    assert data["submissions_list"][0]["id"] == sub2.id
+    assert data["submissions_list"][1]["id"] == sub1.id