Add audit log entries for grant status changes

Author: estyxx

backend/grants/admin.py

@@ -564,6 +564,31 @@ class GrantAdmin(ExportMixin, ConferencePermissionMixin, admin.ModelAdmin):
         ),
     )
 
+    def save_model(self, request, obj, form, change):
+        """
+        Override to log admin actions when status is changed.
+        """
+        if change:
+            if obj.status != obj._original_status:
+                create_change_admin_log_entry(
+                    request.user,
+                    obj,
+                    change_message=f"Status changed from '{obj._original_status}' to '{obj.status}'",
+                )
+            if obj.pending_status != obj._original_pending_status:
+                create_change_admin_log_entry(
+                    request.user,
+                    obj,
+                    change_message=f"Pending status changed from '{obj._original_pending_status}' to '{obj.pending_status}'",
+                )
+        else:
+            create_addition_admin_log_entry(
+                request.user,
+                obj,
+                change_message="Grant created",
+            )
+        super().save_model(request, obj, form, change)
+
     def change_view(self, request, object_id, form_url="", extra_context=None):
         extra_context = extra_context or {}
         grant = self.model.objects.get(id=object_id)

backend/grants/tests/test_admin.py

@@ -11,6 +11,7 @@
 from conferences.tests.factories import ConferenceFactory, ConferenceVoucherFactory
 from grants.admin import (
     confirm_pending_status,
+    GrantAdmin,
     GrantReimbursementAdmin,
     create_grant_vouchers,
     mark_rejected_and_send_email,
@@ -703,3 +704,52 @@ def test_delete_reimbursement_from_admin_logs_audit_log_entry(rf, admin_user):
         object_id=grant.id,
         change_message=f"Reimbursement removed: {reimbursement.category.name}",
     ).exists()
+
+
+def test_save_grant_in_admin_logs_audit_log_entry(rf, admin_user):
+    grant = GrantFactory()
+    request = rf.get("/")
+    request.user = admin_user
+
+    admin = GrantAdmin(Grant, AdminSite())
+    admin.save_model(request, grant, None, False)
+
+    assert LogEntry.objects.filter(
+        user=admin_user,
+        object_id=grant.id,
+        change_message="Grant created",
+    ).exists()
+
+
+def test_save_grant_in_admin_logs_audit_log_entry_for_status_change(rf, admin_user):
+    grant = GrantFactory(status=Grant.Status.pending)
+    request = rf.get("/")
+    request.user = admin_user
+
+    admin = GrantAdmin(Grant, AdminSite())
+    grant.status = Grant.Status.confirmed
+    admin.save_model(request, grant, None, True)
+
+    assert LogEntry.objects.filter(
+        user=admin_user,
+        object_id=grant.id,
+        change_message="Status changed from 'pending' to 'confirmed'",
+    ).exists()
+
+
+def test_save_grant_in_admin_logs_audit_log_entry_for_pending_status_change(
+    rf, admin_user
+):
+    grant = GrantFactory(pending_status=Grant.Status.pending)
+    request = rf.get("/")
+    request.user = admin_user
+
+    admin = GrantAdmin(Grant, AdminSite())
+    grant.pending_status = Grant.Status.confirmed
+    admin.save_model(request, grant, None, True)
+
+    assert LogEntry.objects.filter(
+        user=admin_user,
+        object_id=grant.id,
+        change_message="Pending status changed from 'pending' to 'confirmed'",
+    ).exists()