invalidate

Author: marcoacierno

backend/api/submissions/mutations.py

@@ -1,5 +1,6 @@
 from urllib.parse import urljoin
 from django.conf import settings
+from conferences.frontend import trigger_frontend_revalidate
 from grants.tasks import get_name
 from notifications.models import EmailTemplate, EmailTemplateIdentifier
 from strawberry.scalars import JSON
@@ -386,6 +387,8 @@ def update_submission(
             },
         )
 
+        trigger_frontend_revalidate(conference, instance)
+
         instance.__strawberry_definition__ = Submission.__strawberry_definition__
         return instance
 

backend/conferences/frontend.py

@@ -0,0 +1,44 @@
+from django.db import models
+from submissions.models import Submission
+from schedule.models import ScheduleItem
+from job_board.models import JobListing
+from cms.components.page.tasks import execute_frontend_revalidate
+from conferences.models.conference import Conference
+
+
+def trigger_frontend_revalidate(conference: Conference, object: models.Model):
+    if not conference.frontend_revalidate_url:
+        return
+
+    for path in get_paths(object):
+        for locale in ["en", "it"]:
+            execute_frontend_revalidate.delay(
+                url=conference.frontend_revalidate_url,
+                path=f"/{locale}{path}",
+                secret=conference.frontend_revalidate_secret,
+            )
+
+
+def get_paths(object: models.Model) -> list[str]:
+    match object:
+        case JobListing():
+            return [
+                f"/jobs/{object.id}",
+                "/jobs/",
+            ]
+        case ScheduleItem(type=ScheduleItem.TYPES.keynote):
+            return [
+                f"/keynotes/{object.slug}",
+            ]
+        case ScheduleItem():
+            return [
+                f"/event/{object.slug}",
+            ]
+        case Submission(status=Submission.STATUS.accepted):
+            schedule_items = ScheduleItem.objects.filter(
+                submission_id=object.id,
+                conference=object.conference,
+            )
+            return [f"/event/{schedule_item.slug}" for schedule_item in schedule_items]
+        case _:
+            return []

backend/conferences/tests/test_frontend.py

@@ -0,0 +1,92 @@
+from submissions.models import Submission
+from submissions.tests.factories import SubmissionFactory
+from conferences.tests.factories import ConferenceFactory
+from job_board.tests.factories import JobListingFactory
+from schedule.tests.factories import ScheduleItemFactory
+from conferences.frontend import get_paths, trigger_frontend_revalidate
+from schedule.models import ScheduleItem
+
+
+def test_get_paths_for_keynote():
+    keynote = ScheduleItem(
+        slug="keynote-1",
+        type=ScheduleItem.TYPES.keynote,
+    )
+
+    assert get_paths(keynote) == [
+        "/keynotes/keynote-1",
+    ]
+
+
+def test_get_paths_for_event():
+    event = ScheduleItemFactory(
+        slug="event-1",
+        type=ScheduleItem.TYPES.submission,
+    )
+
+    assert get_paths(event) == [
+        "/event/event-1",
+    ]
+
+
+def test_get_paths_for_job_listing():
+    job_listing = JobListingFactory(
+        id=1,
+    )
+
+    assert get_paths(job_listing) == [
+        "/jobs/1",
+        "/jobs/",
+    ]
+
+
+def test_get_paths_for_unknown_object():
+    assert get_paths(object()) == []
+
+
+def test_get_paths_for_accepted_submission_invalidates_schedule_items():
+    submission = SubmissionFactory(
+        status=Submission.STATUS.accepted,
+    )
+
+    schedule_item = ScheduleItemFactory(
+        submission=submission,
+        conference=submission.conference,
+        type=ScheduleItem.TYPES.talk,
+    )
+
+    assert get_paths(submission) == [
+        f"/event/{schedule_item.slug}",
+    ]
+
+
+def test_trigger_frontend_revalidate(mocker):
+    mock_call = mocker.patch("conferences.frontend.execute_frontend_revalidate.delay")
+
+    conference = ConferenceFactory(
+        frontend_revalidate_url="https://example.com",
+        frontend_revalidate_secret="secret",
+    )
+
+    object = ScheduleItemFactory(
+        slug="event-1",
+        type=ScheduleItem.TYPES.submission,
+    )
+
+    trigger_frontend_revalidate(conference, object)
+
+    mock_call.assert_has_calls(
+        [
+            mocker.call(
+                url="https://example.com",
+                path="/en/event/event-1",
+                secret="secret",
+            ),
+            mocker.call(
+                url="https://example.com",
+                path="/it/event/event-1",
+                secret="secret",
+            ),
+        ],
+        any_order=True,
+    )

backend/job_board/admin.py

@@ -1,5 +1,5 @@
 from django.contrib import admin
-from cms.components.page.tasks import execute_frontend_revalidate
+from conferences.frontend import trigger_frontend_revalidate
 from ordered_model.admin import OrderedModelAdmin
 from custom_admin.widgets import RichEditorWidget
 
@@ -25,14 +25,4 @@ def save_model(self, request, obj, form, change):
         if not conference.frontend_revalidate_url:
             return
 
-        for locale in ["en", "it"]:
-            execute_frontend_revalidate.delay(
-                url=conference.frontend_revalidate_url,
-                path=f"/{locale}/jobs/",
-                secret=conference.frontend_revalidate_secret,
-            )
-            execute_frontend_revalidate.delay(
-                url=conference.frontend_revalidate_url,
-                path=f"/{locale}/jobs/{obj.id}",
-                secret=conference.frontend_revalidate_secret,
-            )
+        trigger_frontend_revalidate(conference, obj)