Skip to content

Commit c3f4de1

Browse files
fix: filter out unpublished pages in cms_page and news_article queries
Add live=True filter to the initial queryset in both cms_page and news_article GraphQL queries to ensure draft/unpublished pages are never returned. Previously, unpublished pages could still be fetched by slug even though only the translated version was being filtered for live status. Fixes #4577 Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
1 parent 6b43dee commit c3f4de1

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

backend/api/cms/news/queries/news_article.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def news_article(hostname: str, slug: str, language: str) -> NewsArticle | None:
1111
if not site:
1212
raise ValueError(f"Site {hostname} not found")
1313

14-
article = NewsArticleModel.objects.in_site(site).filter(slug=slug).first()
14+
article = NewsArticleModel.objects.in_site(site).filter(slug=slug, live=True).first()
1515

1616
if not article:
1717
return None

backend/api/cms/page/queries/cms_page.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def cms_page(
2020
if not site:
2121
return SiteNotFoundError(message=f"Site `{hostname}` not found")
2222

23-
page = GenericPageModel.objects.in_site(site).filter(slug=slug).first()
23+
page = GenericPageModel.objects.in_site(site).filter(slug=slug, live=True).first()
2424

2525
if not page:
2626
return None

0 commit comments

Comments
 (0)