Skip to content

Commit e759b0c

Browse files
refactor: move user existence check into create_grant_card
Each card function now handles its own requirements internally, keeping the view layer clean and making it easier to add new cards. Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
1 parent 1fffd40 commit e759b0c

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

backend/integrations/plain_cards.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@
33

44

55
def create_grant_card(request, user, conference):
6-
grant = Grant.objects.of_user(user).for_conference(conference).first()
6+
grant = (
7+
Grant.objects.of_user(user).for_conference(conference).first()
8+
if user
9+
else None
10+
)
711

812
if not grant:
913
return {"key": "grant", "components": []}

backend/integrations/views.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,6 @@ def plain_customer_cards(request):
3232

3333
cards = []
3434
if "grant" in card_keys:
35-
if user:
36-
cards.append(create_grant_card(request, user, conference))
37-
else:
38-
cards.append({"key": "grant", "components": []})
35+
cards.append(create_grant_card(request, user, conference))
3936

4037
return Response({"cards": cards})

0 commit comments

Comments
 (0)