fix: fallback to sysfs for battery percentage on HID devices#137
Open
jamerrq wants to merge 1 commit intopythops:masterfrom
Open
fix: fallback to sysfs for battery percentage on HID devices#137jamerrq wants to merge 1 commit intopythops:masterfrom
jamerrq wants to merge 1 commit intopythops:masterfrom
Conversation
04f9a6c to
a4fb7f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #134
Problem
Devices like PS4/PS5 controllers report battery via the kernel HID driver
(
/sys/class/power_supply/ps-controller-battery-XX:XX:XX:XX:XX:XX/capacity)instead of the Bluetooth Battery Service profile. Since
blueronly readsfrom
org.bluez.Battery1, these devices always showNonefor battery.Solution
Added a
read_battery_from_sysfs()fallback function that:/sys/class/power_supply/for entries containing the MAC addresscapacityfile to get the battery percentageThis is used as a fallback via
.or_else()only whenbluerreturnsNone.Testing
Tested with: