Skip to content

[MNT] Migrate packaging to pyproject.toml#594

Merged
fkiraly merged 13 commits intopytorch-tabular:mainfrom
fkiraly:migrate-pyproject
Jan 24, 2026
Merged

[MNT] Migrate packaging to pyproject.toml#594
fkiraly merged 13 commits intopytorch-tabular:mainfrom
fkiraly:migrate-pyproject

Conversation

@fkiraly
Copy link
Copy Markdown
Collaborator

@fkiraly fkiraly commented Jan 6, 2026

Migrates packaging to pyproject.toml.

  • move the dependency sets from requirements to pyproject.toml
  • move setup.py and setup.cfg to pyproject.toml

Also carries out a minimal improvement of the testing workflow:

  • remove outdated python 3.8 and 3.9
  • add concurrency handling

Depends on #597 which should be merged first

@phoeenniixx
Copy link
Copy Markdown
Member

Few Observations:

  • torch still supports 1.X, but there is nothing about 2.X support. We should see if it can support torch 2.6+ version completely or not.
  • The project uses pytorch-lightning, I think we should move it to the newer lightning version
  • There are a lot of "core" dependencies. We should look how can we reduce this stack.
    Some dependencies which I think we should check if we could move to extras:
    • omegaconf
    • torchmetrics
    • tensorboard
    • protobuf
    • matplotlib
    • PyYAML
    • matplotlib
    • einops
    • fsspec
    • rich
    • ipywidgets
  • We should also create few more dependency categories in pyproject.toml, like docs etc]
  • We should also look into GH workflows, it is still using older python versions

Comment thread pyproject.toml Outdated
]

urls = {
Homepage = "https://github.com/manujosephv/pytorch_tabular"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be "https://github.com/pytorch-tabular/pytorch_tabular" now? given the creation of the org?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think so - although the old URL forwards to the new one, so it is not a breaking error. I will change this.

@fkiraly
Copy link
Copy Markdown
Collaborator Author

fkiraly commented Jan 9, 2026

Few Observations:

* `torch` still supports 1.X, but there is nothing about 2.X support. We should see if it can support `torch` 2.6+ version completely or not.

* The project uses `pytorch-lightning`, I think we should move it to the newer `lightning` version

* There are a lot of "core" dependencies. We should look how can we reduce this stack.
  Some dependencies which I think we should check if we could move to `extras`:
* We should also create few more dependency categories in `pyproject.toml`, like `docs` etc]

* We should also  look into GH workflows, it is still using older python versions

Fully agreed with all your points - I think they are already covered by this plan here?
#592

Where your statements are of course more granular than the general plan, as to how exactly we isolate, reduce, or update dependencies.

For general plan, I think it is best if you comment on #592 to align on the precise steps?

@fkiraly
Copy link
Copy Markdown
Collaborator Author

fkiraly commented Jan 9, 2026

@phoeenniixx, are you able to start my workflows?

@phoeenniixx
Copy link
Copy Markdown
Member

@phoeenniixx, are you able to start my workflows?

I dont think so, Only maintainers can do so. I dont have write access to this repository. Workflows on my PR is running because I am a member of this org.

@fkiraly
Copy link
Copy Markdown
Collaborator Author

fkiraly commented Jan 9, 2026

I will check with @manujosephv on discord, I think he said we both have write access, but currently that does not seem to be the case?

@fkiraly fkiraly merged commit cfae5ae into pytorch-tabular:main Jan 24, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants