Commit 5f3cdc6
Add MetaHeader parity test addressing D108793458 review comment (#5935)
Summary:
X-link: facebookresearch/FBGEMM#2853
This diff addresses the review comment in D108793458 inline 1189-1193
about hardcoded magic number 16 in values[j].size() >= 16 and
sizeof(int64_t) offset baking in MetaHeader layout assumptions.
Adds SSDTableBatchedEmbeddingsTest.MetaHeaderParityWithDRAM to verify
SSD hard-coded 16-byte header parsing produces identical output to
DRAM FixedBlockPool::get_metaheader_raw for same MetaHeader bytes.
Keeps production ssd_table_batched_embeddings.h unchanged per follow-up
discussion — hard-coded 16 / 8 remains with comment, test is source of
truth for cross-backend parity.
Updates test BUCK dep to include dram_kv_embedding_inference for
FixedBlockPool header access. No production behavior change.
Differential Revision: D1090848191 parent defd174 commit 5f3cdc6
1 file changed
Lines changed: 37 additions & 0 deletions
Lines changed: 37 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
641 | 642 | | |
642 | 643 | | |
643 | 644 | | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
0 commit comments