Skip to content

Commit 9ca82f8

Browse files
gchalumpfacebook-github-bot
authored andcommitted
Fix backward_dense health-check regression under the ci profile
Summary: test_backward_dense started failing in OSS CI on 2026-06-15, green before that. The break is D108096684, which removed the per-test `suppress_health_check=[HealthCheck.filter_too_much, HealthCheck.data_too_large]` from `backward_dense_test.py` and moved the suppressions into the "derandomize" Hypothesis profile registered in `tbe/common.py`. The problem: OSS CI runs under the "ci" Hypothesis profile, not "derandomize". The job log shows: hypothesis profile 'ci' -> ... suppress_health_check=(HealthCheck.too_slow,) so the profile-level suppressions never take effect in OSS. test_backward_dense makes heavy use of assume() (T*B*L*D<=2048, FP16/pooling guards, etc.), which trips HealthCheck.filter_too_much once the suppression is gone, failing the test. Fix: apply the suppressions explicitly in the test's settings via the centralized `suppressed_list` from `tbe/common.py`. This keeps a single source of truth (the list still lives in common.py, including the conditional differing_executors entry) while making the suppression independent of which profile is loaded. Differential Revision: D109164907
1 parent 449ade1 commit 9ca82f8

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

fbgemm_gpu/test/tbe/training/backward_dense_test.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
format_ref_tensors_in_mixed_B_layout,
3333
gen_mixed_B_batch_sizes,
3434
open_source,
35+
suppressed_list,
3536
)
3637

3738
if open_source:
@@ -78,6 +79,13 @@ class BackwardDenseTest(unittest.TestCase):
7879
verbosity=VERBOSITY,
7980
max_examples=10,
8081
deadline=None,
82+
# Apply the health-check suppressions explicitly rather than relying on
83+
# the "derandomize" profile: OSS CI runs under the "ci" Hypothesis
84+
# profile (which only suppresses too_slow), so the profile-level
85+
# suppressions registered in tbe/common.py do not take effect there.
86+
# This test's heavy use of assume() trips filter_too_much/data_too_large
87+
# without these. See D108096684 which moved these into the profile.
88+
suppress_health_check=suppressed_list,
8189
)
8290
def test_backward_dense( # noqa C901
8391
self,

0 commit comments

Comments
 (0)