Fix backward determinism tests#5786
Closed
spcyppt wants to merge 1 commit into
Closed
Conversation
Summary: X-link: facebookresearch/FBGEMM#2716 Fix `BackwardDeterminismTest` failures: - Add `HealthCheck.differing_executors` to `suppress_health_check` since `optests.generate_opcheck_tests` wraps hypothesis tests in multiple executors - Only test for `stochastic_rounding=False` since stochastic rounding is inherently non-deterministic - Add xfail entries in `failures_dict_fast.json` for `dense_embedding_codegen_lookup_function` (no Meta tensor / autograd registration, matching existing `BackwardDenseTest` xfails). The faketensor and autograd opcheck tests will be added in the next diff. - Pass `additional_decorators` to skip known `test_pt2_compliant_tag` failures - Suppress noisy TBE constructor debug/info logs (override with `FBGEMM_TEST_VERBOSE=1`) Differential Revision: D106442327
Contributor
|
@spcyppt has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106442327. |
Contributor
|
This pull request has been merged in 0fcdfc0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2716
Fix
BackwardDeterminismTestfailures:HealthCheck.differing_executorstosuppress_health_checksinceoptests.generate_opcheck_testswraps hypothesis tests in multiple executorsstochastic_rounding=Falsesince stochastic rounding is inherently non-deterministicfailures_dict_fast.jsonfordense_embedding_codegen_lookup_function(no Meta tensor / autograd registration, matching existingBackwardDenseTestxfails). The faketensor and autograd opcheck tests will be added in the next diff.additional_decoratorsto skip knowntest_pt2_compliant_tagfailuresFBGEMM_TEST_VERBOSE=1)Differential Revision: D106442327