Add DRAM_SSD to BackendType enum in tbe/ssd/ssd_config.py#5789
Open
lizhe-ji wants to merge 1 commit into
Open
Conversation
Summary: The BackendType enum in tbe/ssd/ssd_config.py was missing the DRAM_SSD variant (value=3) that already exists in split_table_batched_embeddings_ops_common.py. Since torchrec's embedding_lookup.py imports BackendType from fbgemm_gpu.tbe.ssd first, using EmbeddingComputeKernel.DRAM_SSD_VIRTUAL_TABLE would fail with AttributeError: type object 'BackendType' has no attribute 'DRAM_SSD'. Added DRAM_SSD = 3 and updated from_str() to include the dram_ssd mapping. Differential Revision: D106438433
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The BackendType enum in tbe/ssd/ssd_config.py was missing the DRAM_SSD variant
(value=3) that already exists in split_table_batched_embeddings_ops_common.py.
Since torchrec's embedding_lookup.py imports BackendType from fbgemm_gpu.tbe.ssd
first, using EmbeddingComputeKernel.DRAM_SSD_VIRTUAL_TABLE would fail with
AttributeError: type object 'BackendType' has no attribute 'DRAM_SSD'.
Added DRAM_SSD = 3 and updated from_str() to include the dram_ssd mapping.
Differential Revision: D106438433