Log FQN names and count after streaming to scuba and ODS#5791
Open
adityas-meta wants to merge 1 commit into
Open
Log FQN names and count after streaming to scuba and ODS#5791adityas-meta wants to merge 1 commit into
adityas-meta wants to merge 1 commit into
Conversation
Summary: After every streaming interval, log the names of FQNs streamed and the count of FQNs to both scuba (perfpipe_raw_embedding_streaming) and ODS (fb303 counter res.streamed_fqn_count). This adds observability into which embedding tables are being actively streamed and how many, enabling monitoring via the existing scuba table and ODS dashboards. Changes include: adding fb303 stat export for res.streamed_fqn_count (SUM), initializing a ScubaData writer for the raw_embedding_streaming perfpipe table, and emitting both log lines and structured data after each tensor_stream call completes. Differential Revision: D104076551
adityas-meta
force-pushed
the
export-D104076551
branch
from
6c78209 to
148c633
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: After every streaming interval, log the names of FQNs streamed and the count of FQNs to both scuba (perfpipe_raw_embedding_streaming) and ODS (fb303 counter res.streamed_fqn_count). This adds observability into which embedding tables are being actively streamed and how many, enabling monitoring via the existing scuba table and ODS dashboards. Changes include: adding fb303 stat export for res.streamed_fqn_count (SUM), initializing a ScubaData writer for the raw_embedding_streaming perfpipe table, and emitting both log lines and structured data after each tensor_stream call completes.
Differential Revision: D104076551