Skip to content

Add DRAM_SSD backend type to BackendType enum #5802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lizhe-ji wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add DRAM_SSD backend type to BackendType enum #5802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions fbgemm_gpu/fbgemm_gpu/tbe/ssd/ssd_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,13 +314,15 @@ class BackendType(enum.IntEnum):
SSD = 0
DRAM = 1
PS = 2
DRAM_SSD = 3

@classmethod
def from_str(cls, key: str) -> "BackendType":
lookup = {
"ssd": BackendType.SSD,
"dram": BackendType.DRAM,
"ps": BackendType.PS,
"dram_ssd": BackendType.DRAM_SSD,
}
if key in lookup:
return lookup[key]
Expand Down
11 changes: 11 additions & 0 deletions fbgemm_gpu/test/tbe/ssd/ssd_config_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,17 @@ def test_dram(self) -> None:

self.assertEqual(BackendType.from_str("dram"), BackendType.DRAM)

def test_ps(self) -> None:
from fbgemm_gpu.tbe.ssd import BackendType

self.assertEqual(BackendType.from_str("ps"), BackendType.PS)

def test_dram_ssd(self) -> None:
from fbgemm_gpu.tbe.ssd import BackendType

self.assertEqual(BackendType.from_str("dram_ssd"), BackendType.DRAM_SSD)
self.assertEqual(BackendType.DRAM_SSD.value, 3)

def test_invalid_raises(self) -> None:
from fbgemm_gpu.tbe.ssd import BackendType

Expand Down
Loading